From owner-freebsd-current Sun Apr 19 23:57:20 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id XAA18788 for freebsd-current-outgoing; Sun, 19 Apr 1998 23:57:20 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id GAA18763 for ; Mon, 20 Apr 1998 06:57:17 GMT (envelope-from julian@whistle.com) Received: (from daemon@localhost) by alpo.whistle.com (8.8.5/8.8.5) id XAA18043; Sun, 19 Apr 1998 23:54:02 -0700 (PDT) Received: from current1.whistle.com(207.76.205.22) via SMTP by alpo.whistle.com, id smtpd018024; Mon Apr 20 06:54:00 1998 Date: Sun, 19 Apr 1998 23:48:42 -0700 (PDT) From: Julian Elischer To: Michael Hancock cc: freebsd-current@FreeBSD.ORG Subject: Re: vfs changes synced w/ devfs In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG I went through these patches and they look pretty good for me. I didn't spend the 5 minutes on each patch that a full review would need but I think they look pretty good. "ship it." I'm not sure if my previous response got out. The mailer core-dumped just as it sent it. (in fact I just found the /tmp files so probably they were lost..) it was: -------------------------- I don't see why there should be both vput and vrele surely it's obvious to the 'free' function whether it should be totally zapping it by the bloody reference count.. If the answer is "but there may be transient references as well" then I think They should be counted as well. The DEVFS patches look fine. julian ------------------------ On Mon, 20 Apr 1998, Michael Hancock wrote: > I had a couple of problems with my changes in devfs. The patch has been > updated. http://www.freebsd.org/~mch/vop1a.diff. what was the problem? Everyone who's looked at terry's nameifree fixes has agreed with them too, but I can't find them now, otherwise I was getting ready to put them up for commit as well. julian To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message