From owner-dev-commits-src-main@freebsd.org Sat Jul 10 19:30:26 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 375EE65A79D for ; Sat, 10 Jul 2021 19:30:26 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GMg9G0kbTz4m4L for ; Sat, 10 Jul 2021 19:30:25 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f49.google.com with SMTP id d12so16931321wre.13 for ; Sat, 10 Jul 2021 12:30:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Yjn9x3DUZpCnDncqDYORAKKF/MLImMdTxz74QWi7Xmg=; b=aT7pKSBzUNTyPjqW87KFc6/RI6sxI9bfnB05OotEkl/XCHjMtSjjGHpfP+dwo6tK37 z6KJuHqye8FE9fNT5M39fcEXaWml7M1Z1/jtzKqRUwSA8RCBRZhtr1woPIaB/FVqZ6sb U6pNhywJtlzlPqHHj6awfue/zUc35GbOfZ+XgnwIipx9Jvacn4PRyVpCwkQVDNP1W783 1OexmjpWivqPOpqybPVvYEKn7qKhI4ONRVF0Xa+Jt6f1tbaRY+m+Lb9P5p6mXMKpLmDC Fn1NN+DgL6PAEsxNX6K9CGYjzRofYerOBxFlWN7qveQelv9Ud0Z/V5eQLON4J5R8+oxs bX4g== X-Gm-Message-State: AOAM531y7NnjHzuQlYZKkkOr28y5IY3+U7RTmf4FNCmhhtseeN6klMhd /okcBCljc+gkHeE6Ovy/zfRABg== X-Google-Smtp-Source: ABdhPJxEywK2rff1ISliAJuqJqr7ehsgzcwhi5tf5yESNYo3EuVqSvY3FgsROoEuzxSuils7pfN5ag== X-Received: by 2002:a5d:47a7:: with SMTP id 7mr17974773wrb.150.1625945424755; Sat, 10 Jul 2021 12:30:24 -0700 (PDT) Received: from smtpclient.apple (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id x19sm8214198wmi.10.2021.07.10.12.30.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Jul 2021 12:30:24 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Subject: Re: git: d038463bd269 - main - Make sure the XHCI driver obeys the isochronous scheduling threshold value as given by the XHCI hardware parameters to avoid scheduling isochronous transfers too early. From: Jessica Clarke In-Reply-To: <202107101904.16AJ4lj3035432@gitrepo.freebsd.org> Date: Sat, 10 Jul 2021 20:30:22 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <09444339-973B-4A2B-ACEA-B00B8E48F460@freebsd.org> References: <202107101904.16AJ4lj3035432@gitrepo.freebsd.org> To: Hans Petter Selasky X-Mailer: Apple Mail (2.3654.100.0.2.22) X-Rspamd-Queue-Id: 4GMg9G0kbTz4m4L X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Jul 2021 19:30:26 -0000 On 10 Jul 2021, at 20:04, Hans Petter Selasky = wrote: >=20 > The branch main has been updated by hselasky: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dd038463bd269031fa8f13c0951b223bc= ae02bbca >=20 > commit d038463bd269031fa8f13c0951b223bcae02bbca > Author: Hans Petter Selasky > AuthorDate: 2021-07-10 16:09:56 +0000 > Commit: Hans Petter Selasky > CommitDate: 2021-07-10 17:57:52 +0000 >=20 > Make sure the XHCI driver obeys the isochronous scheduling = threshold value > as given by the XHCI hardware parameters to avoid scheduling = isochronous > transfers too early. >=20 > MFC after: 1 week > Sponsored by: NVIDIA Networking > --- > sys/dev/usb/controller/xhci.c | 11 ++++++++++- > sys/dev/usb/controller/xhci.h | 3 +++ > 2 files changed, 13 insertions(+), 1 deletion(-) >=20 > diff --git a/sys/dev/usb/controller/xhci.c = b/sys/dev/usb/controller/xhci.c > index 10e37c97c254..dd64c2d45141 100644 > --- a/sys/dev/usb/controller/xhci.c > +++ b/sys/dev/usb/controller/xhci.c > @@ -644,6 +644,9 @@ xhci_init(struct xhci_softc *sc, device_t self, = uint8_t dma32) >=20 > DPRINTF("HCS2=3D0x%08x\n", temp); >=20 > + /* get isochronous scheduling threshold */ > + sc->sc_ist =3D XHCI_HCS2_IST(temp); > + > /* get number of scratchpads */ > sc->sc_noscratch =3D XHCI_HCS2_SPB_MAX(temp); >=20 > @@ -2075,7 +2078,13 @@ xhci_setup_generic_chain(struct usb_xfer *xfer) >=20 > x =3D XREAD4(temp.sc, runt, XHCI_MFINDEX); >=20 > - DPRINTF("MFINDEX=3D0x%08x\n", x); > + DPRINTF("MFINDEX=3D0x%08x IST=3D0x%x\n", x, sc->sc_ist); This broke amd64 GENERIC with error: use of undeclared identifier =E2=80=98= sc' Should this be temp.sc? Jess