Date: Tue, 24 May 2016 14:50:45 +0200 From: John Marino <freebsd.contact@marino.st> To: Mathieu Arnold <mat@FreeBSD.org>, marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r415493 - in head/games/libretro-cores: . files Message-ID: <17614e8e-01c9-eeeb-4752-758e5d7112fc@marino.st> In-Reply-To: <2A9F124F55BB011FD665C0A4@ogg.in.absolight.net> References: <201605190700.u4J70sfs011294@repo.freebsd.org> <307385ca-1cd1-83ae-1a66-b2a7210b5054@marino.st> <2A9F124F55BB011FD665C0A4@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5/24/2016 2:31 PM, Mathieu Arnold wrote:
> +--On 24 mai 2016 12:05:25 +0200 John Marino <freebsd.contact@marino.st>
> wrote:
> |> do-build:
> |> @for dir in ${CORE_DIRS}; do \
> |> - ${ECHO_MSG} "===> Building for ${PKGNAME}: core $${dir} (`date`)"; \
> |> - if [ -f ${WRKSRC}/$${dir}/Makefile.freebsd ]; then \
> |> - (cd ${WRKSRC}/$${dir} && ${SETENV} ${MAKE_ENV} ${MAKE_CMD}
> |> ${MAKE_FLAGS} Makefile.freebsd ${_MAKE_JOBS} ${MAKE_ARGS}); \ - elif [
> |> -f ${WRKSRC}/$${dir}/Makefile.libretro ]; then \
> |> - (cd ${WRKSRC}/$${dir} && ${SETENV} ${MAKE_ENV} ${MAKE_CMD}
> |> ${MAKE_FLAGS} Makefile.libretro ${_MAKE_JOBS} ${MAKE_ARGS}); \ +
> |> ${ECHO_MSG} "===> Building for ${PKGNAME}: core ${dir} ($$(date))"; \ +
> |> cd ${WRKSRC}/${dir}; \
> |
> | We think this is a mistake:
> | changing "cd ${WRKSRC}/$${dir};" to "cd ${WRKSRC}/${dir};"
> | ("core $${dir}" => "core ${dir}" is wrong too but that's only an echo
> | issue)
> |
> | I'm wondering how this is working on FreeBSD actually ...
>
> Mmmm, good catch, I changed it back from a make .for to a shell one at the
> last minute and messed it up.
There's a second problem too.
You have to revert this one:
- ${CP} $$(find ${WRKSRC}/$${dir} -name "*.so")
${STAGEDIR}/${PREFIX}/libexec/libretro/; \
+ ${INSTALL_LIB} $$(find ${WRKSRC}/${dir}/ -name "*.so")
${STAGEDIR}/${PREFIX}/libexec/libretro); \
The last ")" prevents installation from installating. It fails for us
outright on the during staging.
Thanks,
John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?17614e8e-01c9-eeeb-4752-758e5d7112fc>