From owner-freebsd-hackers Tue Jan 21 20: 7: 2 2003 Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 989CA37B401 for ; Tue, 21 Jan 2003 20:07:01 -0800 (PST) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4BCEC43EB2 for ; Tue, 21 Jan 2003 20:07:01 -0800 (PST) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id 37A442A7EA; Tue, 21 Jan 2003 20:07:01 -0800 (PST) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Matthew Dillon Cc: Kris Kennaway , hackers@FreeBSD.ORG, Hiten Pandya Subject: Re: patch to remove random #define MIN/MAX implementations from around the kernel In-Reply-To: <200301220402.h0M42xBo000193@apollo.backplane.com> Date: Tue, 21 Jan 2003 20:07:01 -0800 From: Peter Wemm Message-Id: <20030122040701.37A442A7EA@canning.wemm.org> Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Matthew Dillon wrote: > > :On Tue, Jan 21, 2003 at 07:25:44PM -0800, Matthew Dillon wrote: > :> This patch is going to go in on the weekend unless someone has any > :> worthwhile nits about it. It was submitted by Hiten Pandya. > : > :> Index: contrib/dev/oltr/if_oltr.c > : > :> Index: contrib/ipfilter/netinet/ip_proxy.c > : > :> Index: netinet6/nd6.c > : > :You shouldn't modify vendor code for minor purposes. > : > :Kris > > The vendor code in question has been modified *extensively* since > it was imported, (and of course I would give Darren a head's up in > regards to ipfilter). Unless you have a more specific reason I don't > really think a general blanket statement is sufficient reason to not > do the commit, at least not in this case. Didn't we explicitly make it like this? ie: you'd be backing out a previous set of intentional commits by doing this... Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message