Date: Mon, 5 Oct 2020 13:46:14 +0200 (CEST) From: Ronald Klop <ronald-lists@klop.ws> To: Hans Petter Selasky <hselasky@FreeBSD.org> Cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r366431 - head/sys/dev/usb/serial Message-ID: <476286772.120.1601898374873@localhost> In-Reply-To: <202010041717.094HHH9d069578@repo.freebsd.org> References: <202010041717.094HHH9d069578@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, I was interested by this commit. But the commit and commit message don't have much information. I was surprised that the "Differential Revision" link contains a lot of info about this. How permanent is this review.freebsd.org server? Wil it stay after the git migration? Ronald. Van: Hans Petter Selasky <hselasky@FreeBSD.org> Datum: zondag, 4 oktober 2020 19:17 Aan: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Onderwerp: svn commit: r366431 - head/sys/dev/usb/serial > > Author: hselasky > Date: Sun Oct 4 17:17:16 2020 > New Revision: 366431 > URL: https://svnweb.freebsd.org/changeset/base/366431 > > Log: > Add support for Google Cr50 (GSC) Closed Case Debugging UART interfaces to > the USB generic serial port driver, ugensa. > > MFC after: 1 week > Differential Revision: https://reviews.freebsd.org/D21863 > Submitted by: greg_unrelenting.technology (Greg V) > Sponsored by: Mellanox Technologies // NVIDIA Networking > > Modified: > head/sys/dev/usb/serial/ugensa.c > > Modified: head/sys/dev/usb/serial/ugensa.c > ============================================================================== > --- head/sys/dev/usb/serial/ugensa.c Sun Oct 4 17:07:13 2020 (r366430) > +++ head/sys/dev/usb/serial/ugensa.c Sun Oct 4 17:17:16 2020 (r366431) > @@ -161,6 +161,8 @@ static const STRUCT_USB_HOST_ID ugensa_devs[] = { > {USB_VPI(USB_VENDOR_KYOCERA2, USB_PRODUCT_KYOCERA2_CDMA_MSM_K, 1)}, > {USB_VPI(USB_VENDOR_HP, USB_PRODUCT_HP_49GPLUS, 1)}, > {USB_VPI(USB_VENDOR_NOVATEL2, USB_PRODUCT_NOVATEL2_FLEXPACKGPS, 3)}, > + {USB_VENDOR(USB_VENDOR_GOOGLE), USB_IFACE_CLASS(UICLASS_VENDOR), > + USB_IFACE_SUBCLASS(0x50), USB_IFACE_PROTOCOL(0x01), USB_DRIVER_INFO(10)}, > }; > > DRIVER_MODULE(ugensa, uhub, ugensa_driver, ugensa_devclass, NULL, 0); > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > > > From owner-svn-src-head@freebsd.org Mon Oct 5 12:37:17 2020 Return-Path: <owner-svn-src-head@freebsd.org> Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2E5E14235F8; Mon, 5 Oct 2020 12:37:17 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C4g8q61Hpz3Zq4; Mon, 5 Oct 2020 12:37:15 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io1-f67.google.com with SMTP id y13so8921471iow.4; Mon, 05 Oct 2020 05:37:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ruj7YXqcHJ0ni/R9UmL0/eL7NwcVrTCuUSZjxFrDC4k=; b=XbLvVr5wcjmbi8kVWiofvtonHzH6bKDnj5GOqBHQdmEXKRJyZo6JAcTVZsf7tQGh7j 7czS0zJcXlo0/q3DiLv4SIV0BoNCcE5uqyLI4BySmeuQu9PAdftj7HJaaGw1i0qAUCZ5 CEENdqym0uMKMY1tU9A3jZ8ojocnm6I1lV5LfyRWVwjFd1ZO/jtrOfFTYWnfyLVr9ePw dOe0nKhIO1N11GngVB/Xhx88x/BZ3u854VKOyMF95VuaYievU1OB4TADk46dtfACBTXm gxt4bhsfoBUirLH5J7BbEVV/zd/ilxcHrOkKi+yeNZzWX1w9ru8yEhLCg003r5MdwoG0 lrzQ== X-Gm-Message-State: AOAM531VKIEfOYJgYLYDKg91TcFLXbbqB1xc+SjTfxLqWHoE107Rv9/n gj5PEGvYGX52TZ9439t68n74ZgjY9P6DJd9e4g6c9PTy X-Google-Smtp-Source: ABdhPJwB3Nq3dUyXx9doZJ/G3iw3wPDfh64w5AwnAKFdSLLkeoESbAhvPW8AD79Oy3JCK0guzQq5cEk9i8AdpRSLcyQ= X-Received: by 2002:a05:6638:14c8:: with SMTP id l8mr13042649jak.136.1601901434055; Mon, 05 Oct 2020 05:37:14 -0700 (PDT) MIME-Version: 1.0 References: <202010041717.094HHH9d069578@repo.freebsd.org> <476286772.120.1601898374873@localhost> In-Reply-To: <476286772.120.1601898374873@localhost> From: Ed Maste <emaste@freebsd.org> Date: Mon, 5 Oct 2020 08:37:02 -0400 Message-ID: <CAPyFy2Dsgo_MU9TXUxpJjS831arWZ3Fh2kuXCW5Y7WfaRQ+W5A@mail.gmail.com> Subject: Re: svn commit: r366431 - head/sys/dev/usb/serial To: Ronald Klop <ronald-lists@klop.ws> Cc: Hans Petter Selasky <hselasky@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org>, src-committers <src-committers@freebsd.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4C4g8q61Hpz3Zq4 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of carpeddiem@gmail.com designates 209.85.166.67 as permitted sender) smtp.mailfrom=carpeddiem@gmail.com X-Spamd-Result: default: False [-1.74 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FREEFALL_USER(0.00)[carpeddiem]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-0.91)[-0.909]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.97)[-0.965]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.166.67:from]; NEURAL_SPAM_SHORT(0.14)[0.137]; FORGED_SENDER(0.30)[emaste@freebsd.org,carpeddiem@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.166.67:from]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MIME_TRACE(0.00)[0:+]; FROM_NEQ_ENVFROM(0.00)[emaste@freebsd.org,carpeddiem@gmail.com]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current <svn-src-head.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>, <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>; List-Post: <mailto:svn-src-head@freebsd.org> List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>, <mailto:svn-src-head-request@freebsd.org?subject=subscribe> X-List-Received-Date: Mon, 05 Oct 2020 12:37:17 -0000 On Mon, 5 Oct 2020 at 07:46, Ronald Klop <ronald-lists@klop.ws> wrote: > > Hi, > > I was interested by this commit. But the commit and commit message don't = have much information. I was surprised that the "Differential Revision" lin= k contains a lot of info about this. How permanent is this review.freebsd.o= rg server? Wil it stay after the git migration? It will remain, but commit messages ought to contain all of the information necessary to make sense of the commit even in the absence of reviews.freebsd.org.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?476286772.120.1601898374873>