From owner-freebsd-current@FreeBSD.ORG Wed Oct 27 16:24:36 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0458716A4CE for ; Wed, 27 Oct 2004 16:24:36 +0000 (GMT) Received: from rproxy.gmail.com (rproxy.gmail.com [64.233.170.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id A68BC43D2D for ; Wed, 27 Oct 2004 16:24:35 +0000 (GMT) (envelope-from dettloff@gmail.com) Received: by rproxy.gmail.com with SMTP id v30so61787rnb for ; Wed, 27 Oct 2004 09:24:35 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=AdFNd+gsYWLyWoxlphBKrKyNoDE7Ymu3RoHjMwOvNtryKGc9SNgapNXFsYdqdoVs9yGqUQZ7wYKU5pxlFTM0ONjiDpOZmMMzaGUqIOdcOFFK8HNHJFPyoaq67A9a70m7vQLJN9CRGDjEFaHgEe33WaqpWU/yOk3o/0vv8DowGpM= Received: by 10.38.12.80 with SMTP id 80mr545114rnl; Wed, 27 Oct 2004 09:24:35 -0700 (PDT) Received: by 10.38.8.3 with HTTP; Wed, 27 Oct 2004 09:24:35 -0700 (PDT) Message-ID: <5b0444b50410270924566f0f59@mail.gmail.com> Date: Wed, 27 Oct 2004 18:24:35 +0200 From: Tim Dettloff To: current@freebsd.org In-Reply-To: <60398.1098860148@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit References: <200410261704.49182.jhb@FreeBSD.org> <60398.1098860148@critter.freebsd.dk> Subject: Re: Solution? Re: pxe-install on FreeBSD 5.3 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Tim Dettloff List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Oct 2004 16:24:36 -0000 Does the loader have enough information? Does it for instance know if NFS support is compiled into the kernel? Maybe set vfs.root.mountfrom should be an ordered list set by the loader. On Wed, 27 Oct 2004 08:55:48 +0200, Poul-Henning Kamp wrote: > In message <200410261704.49182.jhb@FreeBSD.org>, John Baldwin writes: > > > >On Thursday 21 October 2004 05:24 pm, Poul-Henning Kamp wrote: > >> In message <200410211505.27635.jhb@FreeBSD.org>, John Baldwin writes: > >> >> Doesn't the search terminate if [0] is NULL ? > >> > > >> >Perhaps there should be a small wrapper function to register a candidate > >> > root with an associated priority and that wrapper function could then > >> > manage the rootdevnames[] array and keep them sorted based on the > >> > priority? > >> > >> No, the entire thing should be rototiled. > > > >Well, the interface I'm thinking of is something like > >'rootdevice_add(const char *name, int priority)' or maybe > >'rootdevice_add(dev_t dev, int priority)' (which won't work for NFS, so I > >guess back to the char * version) and not having the array or linked list or > >whatever of names visible outside vfs_mount.c (or where the root mount code > >lives). > > After looking again I think I'll change my position: This entire thing > should be yanked out and we should rely on the loader to set the right > variables instead. > > -- > > > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > phk@FreeBSD.ORG | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. >