From owner-freebsd-bugs  Sun May 18 13:22:59 1997
Return-Path: <owner-bugs>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id NAA10811
          for bugs-outgoing; Sun, 18 May 1997 13:22:59 -0700 (PDT)
Received: from implode.root.com (implode.root.com [198.145.90.17])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id NAA10804
          for <freebsd-bugs@hub.freebsd.org>; Sun, 18 May 1997 13:22:57 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1])
	by implode.root.com (8.8.5/8.8.5) with SMTP id NAA27285;
	Sun, 18 May 1997 13:24:25 -0700 (PDT)
Message-Id: <199705182024.NAA27285@implode.root.com>
X-Authentication-Warning: implode.root.com: localhost [127.0.0.1] didn't use HELO protocol
To: "Justin T. Gibbs" <gibbs@plutotech.com>
cc: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>,
        freebsd-bugs@hub.freebsd.org
Subject: Re: kern/3618: getsockname and getpeername may cause trap 12 
In-reply-to: Your message of "Sun, 18 May 1997 14:48:41 MDT."
             <199705181950.NAA19710@pluto.plutotech.com> 
From: David Greenman <dg@root.com>
Reply-To: dg@root.com
Date: Sun, 18 May 1997 13:24:25 -0700
Sender: owner-bugs@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

>> <<On Sun, 18 May 1997 15:08:52 +0200 (CEST), Tor Egge <Tor.Egge@idt.ntnu.no> 
>>said:
>> 
>> > During the getsockname() or getpeername() call, a network interrupt
>> > might reset the connection, causing the socket to no longer have a pcb.
>> > If this happens at the wrong time, the system gets a trap 12.
>> 
>> This fix looks OK.  You have commit privs...
>
>I think that the splnet() and perhaps the other initializers should be
>broken appart from the declarations since, as I recall, he compiler can
>re-order the initializations if it doesn't see any interdependancies.
>It would also make it clearer exactly which actions need splnet protection.

   I agree. It's the one thing that caught my eye immediately when I looked at
the diff.

-DG

David Greenman
Core-team/Principal Architect, The FreeBSD Project