From nobody Wed Feb 5 20:33:08 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YpBks2l7yz5mLxh; Wed, 05 Feb 2025 20:33:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YpBks0lcXz3G5N; Wed, 05 Feb 2025 20:33:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738787589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=E7n1ADHeoUfRUetR439mj/37NcfYKiiDAWTy8SklF3Q=; b=xlHmRg4P30pZi5TMBHvaFhxXlfpzGRZ20bS5zAUt5XqGYDTxsfpMFfb43nF1PRlc42K+J4 CSfMLvAYB3ke3YFm8N1kx/+E16Cr5ahw4djq+TC4XvmeagaCBSVwVgwhsPy0syrxksbcDI UPhF8t8NS5KlUkCWdv8pPN/HZ0hLrVOYPi/XoMQqcA8G08xzwkkx1uVawjhRKqR4h76PMp S854hrnFQX0rt04jPJ9sTvRdkr0Xy0X1u7eiwVxIKZCt/svLPkKsRKgRjNP1yATdHepRpx IZt36OwUXUe0yikQkZbdcvKmnkgwEvvtnADrCr+2cDI64PI8gZagqHW4n7PLbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738787589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=E7n1ADHeoUfRUetR439mj/37NcfYKiiDAWTy8SklF3Q=; b=XkthPE1huP1OiJM+XTM2avCy1HBiYpoIXypk3lZbVDAfE3jr+PEhcXm6gsuvmA4hHIziUb oXrZs1FfUQIJuhXJNtM1ZLmXeC4fFtrHXdCZ1qqPmfeGKfouItTJyKiP+YSkvjoPOfaxap gmvjXhLTI4d5RwF02moxrimgK9ssow+kZ6I5/Brf92LZDynESLYODvCALSHgJYRpjyQW3C nhbT758PAkZei0xkVzMPko2dOzSUzi+Km28zxt54+hlTpTcAvAuOq7kpkY9kz2RhS1RG3h MLlzjT/Zuy3d3cpAyqYuBUNjRAveus10ovwP2PxW9lHps0nlBvH0We5PrN5fOQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738787589; a=rsa-sha256; cv=none; b=Z7c1e/7QJltYf6IFdrL6KI1osmFo0xbswpLv7sYzTWxm+GjS+NdJ25ZsPyFSGFJGD+H7+w e/Pn82Jgi5zjTwwOuXUjYJc5Yp8fEFQZxN+C9E93cRjz/bFVZCX0WI+QJy4nRvhcL29W/1 Md9HqUDs32Xx5ixOaOGmxpMljM9NKx/3f/48t17PuIMa0M5yRcu4Ci2rQzAAhSd9i+WN8s vQJvkzCiA7oCxuyLjjzBulRm754lrFz4s4SpvqyuRCPbABCsdNq76tlnNMcikX0A41rjg/ EN0XBL0Q0gGqq3gYMTrvQ6LOrjPZY32E2//GPhyo9DgjIp21Mq9Woa0yquykGQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YpBks0Kp0z16d9; Wed, 05 Feb 2025 20:33:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 515KX8RS063024; Wed, 5 Feb 2025 20:33:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 515KX8L1063021; Wed, 5 Feb 2025 20:33:08 GMT (envelope-from git) Date: Wed, 5 Feb 2025 20:33:08 GMT Message-Id: <202502052033.515KX8L1063021@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 080caa0aea25 - stable/14 - TCP RACK: avoid using uninitialized tot_idle variable List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 080caa0aea258fe64b48fc43b38af5102c1a3a43 Auto-Submitted: auto-generated The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=080caa0aea258fe64b48fc43b38af5102c1a3a43 commit 080caa0aea258fe64b48fc43b38af5102c1a3a43 Author: Michael Tuexen AuthorDate: 2025-01-01 17:42:00 +0000 Commit: Michael Tuexen CommitDate: 2025-02-05 09:33:29 +0000 TCP RACK: avoid using uninitialized tot_idle variable Reviewed by: rrs CID: 1540027 Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D48277 (cherry picked from commit 3b9da3dcd11f3d73281383c4ba383a4fcc4b9bbe) --- sys/netinet/tcp_stacks/rack.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index 393ca3ca21f6..9ac923ce760c 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -20205,7 +20205,8 @@ rack_output(struct tcpcb *tp) rack_exit_probertt(rack, cts); } } - } + } else + tot_idle = 0; if (rack_use_fsb && (rack->r_ctl.fsb.tcp_ip_hdr) && (rack->r_fsb_inited == 0) &&