From nobody Sun May 18 20:30:55 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4b0ssT3lNzz5wnKQ for ; Sun, 18 May 2025 20:31:09 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4b0ssT1Cc0z4PYS for ; Sun, 18 May 2025 20:31:09 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-442ea341570so23347405e9.1 for ; Sun, 18 May 2025 13:31:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747600267; x=1748205067; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0tdfexrHXCC4tJgqMeIDRqgBuE5cTJCzKVuIaNTAROY=; b=YHY+SuVYFVv3T21wP0feh8UgqGigLthSZRoK5zqhyouDGCFGWRzoHfo0xGYtvZXOod zaKwOKX8IRiS7MEixb8JWGXKleOrPkhLs8y50F4GJce9a549JEvHd/TeGo+GxepzfGFp rYAYA4kwMtVU3Pc10vnlDgERqHsWh4rP+F7Kxc7DDuJbfzdhyRMa89M6OLBHFj3MakwF ++R7yUJwtuCBviWSRawXm4IU5Md05dw6l1t9XC1Pu64SL2cvYIFTDd7y3UUnzMC/nz77 tCoqtrO/Wx1Lvr0T1hKVvv/Ri0MRUxxjn/k5fOZRZYqlhD7ihyIpHf5mipk3imdWef4T 8uHw== X-Forwarded-Encrypted: i=1; AJvYcCXRPCqKQHtNjCqyPPd0f2dDlQ6Tpvuud3aLNLfq7FHQIYEXDiDBOw+mIkhZUGqJrp5wnBZ4bM4e6bOT4BSHD0SO3qXabg==@freebsd.org X-Gm-Message-State: AOJu0YybsMiiEjHz9F0sPX9XmBwnW6Y0QuyBmssf32md0FWnpjiLHfgY 4RNpEJ6VvvxcK/ruIANRohwWWZZTg+7cn9DURasIZw6BkJ6fOuqgl+9ZCkv+DFXhkMg= X-Gm-Gg: ASbGncuICXD9H9nKwCQaBS1gz8lxVjbAVfeOO3rhlZIANBfBqPtTPvbASGxEvXdVYV2 Z9zHyXfEbnvvi/aasHHSynA6uo4B4uWjDpUeuMJ4wdhBOdE0u6utBNtw4/036M3lacDD4s6ksi0 FM0J4SDAOiCcSsWgAhByrWwfFoBmQGMu6tJd1IT+BVJ5PModzd6+9GEcL4eWJ7tAKPdbE6+/kzG vokfqy5yRP+yF/rpv/ZfaFpLwytp+sYWB66saezyAu+1XJibq/oVDW9URsDLE0ugJikYzGIBmJT vvNOT3Q0MiPhCbNHhxJMTMFTlh66waBg3Iwq189xPd5B8nSTQSdGr9NmVXm487DVJg== X-Google-Smtp-Source: AGHT+IG+i7r6o+Sc2/8ZbKLKDrwOBsB2nipqrz6jYDUHvrRHYgIGlPwozYlUleAnG6g1YlWXBREGwQ== X-Received: by 2002:a5d:598f:0:b0:3a2:1f1:c3ad with SMTP id ffacd0b85a97d-3a35fe92b09mr7363774f8f.26.1747600266933; Sun, 18 May 2025 13:31:06 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca5a03fsm10190013f8f.22.2025.05.18.13.31.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 May 2025 13:31:06 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.500.181.1.5\)) Subject: Re: git: b61850c4e6f6 - main - bridge(4): default net.link.bridge.member_ifaddrs to false From: Jessica Clarke In-Reply-To: Date: Sun, 18 May 2025 21:30:55 +0100 Cc: Mitchell Horne , Lexi Winter , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <82C39393-F26D-4E7B-B62A-5CC9C85BAD1A@freebsd.org> References: <202505150004.54F04FhR046897@gitrepo.freebsd.org> To: Mark Johnston X-Mailer: Apple Mail (2.3826.500.181.1.5) X-Rspamd-Queue-Id: 4b0ssT1Cc0z4PYS X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Spamd-Bar: ---- On 18 May 2025, at 21:23, Mark Johnston wrote: > On Sun, May 18, 2025 at 07:53:14PM +0100, Jessica Clarke wrote: >> On 17 May 2025, at 22:18, Mitchell Horne wrote: >>> On 5/14/25 21:04, Lexi Winter wrote: >>>> The branch main has been updated by ivy: >>>>=20 >>>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Db61850c4e6f6b0f21b36da7238db969d= 9090309e >>>>=20 >>>> commit b61850c4e6f6b0f21b36da7238db969d9090309e >>>> Author: Lexi Winter >>>> AuthorDate: 2025-05-14 14:26:24 +0000 >>>> Commit: Lexi Winter >>>> CommitDate: 2025-05-15 00:02:52 +0000 >>>>=20 >>>> bridge(4): default net.link.bridge.member_ifaddrs to false >>>>=20 >>>> As discussed on arch@, this behaviour is broken and confuses = users, so >>>> disable it by default. For 15.0-RELEASE, allow it to be = re-enabled >>>> using a sysctl, but the sysctl will be removed in 16.0R. >>>>=20 >>>=20 >>> Hi Lexi, >>>=20 >>> I just updated my workstation past this commit. I found that my main >>> ethernet interface didn't receive an IP address, and had to set the >>> sysctl to proceed as before. >>>=20 >>> I have the following network configuration lines in my rc.conf: >>>=20 >>> ifconfig_re0=3D"DHCP" >>> cloned_interfaces=3D"bridge0 tap0" >>> ifconfig_bridge0=3D"addm re0 addm tap0 up" >>=20 >> I also have a setup like this, as I suspect many do. >=20 > I do too. >=20 >> The handbook even >> gives this configuration in places[1] (though note it=E2=80=99s = inconsistent in >> whether the interface or bridge should have the address). The lack of >> interaction with devd to automatically run dhclient as re0 comes and >> goes is also rather sucky, especially if re0 is wlan0. I appreciate >> that there may well be good technical reasons why this shouldn=E2=80=99= t be >> what people do, but (a) it is for specifically this case and I think >> it=E2=80=99s a bit shortsighted to go and break something we still = document >> today as correct (b) the UX needs improving specifically for bridging = a >> real interface to one or more tap ones before we enforce this. >=20 > I agree. Even if the setup is broken in some way, it works fine for > simple cases and this will be a nasty surprise when upgrading. >=20 > It would be much better IMO to print a warning and let users fix their > configuration before flipping the default. That is how we handled > interface address configuration without a netmask: commit d8237b955528 > added a warning, and some time later it was turned into a fatal error. > I really think it would be better to do something similar here. That would go some way to helping, but I really do not want =E2=80=9CI = want a tap interface for a VM=E2=80=9D and =E2=80=9CI want devd+dhclient to = manage DHCP for me automatically=E2=80=9D to be incompatible, which based on the thread = here it sounds like they are. Somebody needs to fix that before we even warn users not to do what they=E2=80=99re doing, let alone make it an error. Especially given that SYNCDHCP is not compatible with WPA, given that just runs wpa_supplicant as a daemon and relies on that later triggering dhclient? Jess