From owner-freebsd-current@FreeBSD.ORG Wed Feb 18 11:04:43 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5E02616A4CE for ; Wed, 18 Feb 2004 11:04:43 -0800 (PST) Received: from kazi.fit.vutbr.cz (kazi.fit.vutbr.cz [147.229.8.12]) by mx1.FreeBSD.org (Postfix) with ESMTP id CF6A143D31 for ; Wed, 18 Feb 2004 11:04:42 -0800 (PST) (envelope-from cejkar@fit.vutbr.cz) Received: from kazi.fit.vutbr.cz (localhost [127.0.0.1]) by kazi.fit.vutbr.cz (8.12.11/8.12.11) with ESMTP id i1IJ4eId084500 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Wed, 18 Feb 2004 20:04:40 +0100 (CET) Received: (from cejkar@localhost) by kazi.fit.vutbr.cz (8.12.11/8.12.5/Submit) id i1IJ4dUa084499; Wed, 18 Feb 2004 20:04:39 +0100 (CET) X-Authentication-Warning: kazi.fit.vutbr.cz: cejkar set sender to cejkar@fit.vutbr.cz using -f Date: Wed, 18 Feb 2004 20:04:39 +0100 From: Rudolf Cejka To: freebsd-current@freebsd.org Message-ID: <20040218190439.GA84386@fit.vutbr.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2i X-Scanned-By: MIMEDefang 2.16 (www . roaringpenguin . com / mimedefang) cc: nate@root.org Subject: Problems with power button after latest acpi_button.c 1.18 change X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2004 19:04:43 -0000 Hello, after latest change to src/sys/dev/acpica/acpi_button.c, revision 1.18, I have problems with power-button on my Asus L4000L notebook, now it works just in some cases: System boot -> Press Power button -> Nothing happens = bad However: System boot -> Press Fn+Zz -> System is sleeping -> Space -> System is running again -> Press Power button -> Systems goes down - ok After reverting part of 1.18 change (see below), power button does work again in all cases. Are you interested in some output from my notebook? Do you know about notebooks, for which it helps and for which it breaks something as for my Asus? Thanks. --- sys/dev/acpica/acpi_button.c.orig Wed Feb 18 10:38:18 2004 +++ sys/dev/acpica/acpi_button.c Wed Feb 18 10:43:44 2004 @@ -147,22 +147,6 @@ } acpi_device_enable_wake_capability(sc->button_handle, 1); - /* - * If we have fixed buttons defined in the FADT, remove them now that - * we have found one in the AML. Some systems define buttons both ways - * but only deliver events to the AML object. - */ - if (event == ACPI_EVENT_POWER_BUTTON && AcpiGbl_FADT->PwrButton == 0) { - AcpiDisableEvent(event, 0); - AcpiClearEvent(event); - AcpiRemoveFixedEventHandler(event, acpi_event_power_button_sleep); - } - if (event == ACPI_EVENT_SLEEP_BUTTON && AcpiGbl_FADT->SleepButton == 0) { - AcpiDisableEvent(event, 0); - AcpiClearEvent(event); - AcpiRemoveFixedEventHandler(event, acpi_event_sleep_button_sleep); - } - return_VALUE (0); } -- Rudolf Cejka http://www.fit.vutbr.cz/~cejkar Brno University of Technology, Faculty of Information Technology Bozetechova 2, 612 66 Brno, Czech Republic