Date: Mon, 21 Feb 2005 12:41:46 +1100 From: Sam Lawrance <boris@brooknet.com.au> To: krion@freebsd.org Cc: ports@freebsd.org Subject: bsd.port.mk 1.508 and PORTDOCS globbing Message-ID: <1108950106.664.14.camel@dirk.no.domain>
next in thread | raw e-mail | index | archive | help
The changes to bsd.port.mk 1.508 don't work as expected with globbing.
PORTDOCS is supposed to allow shell glob patterns. Here's the offending
code, now on line 4796:
+.for x in ${PORTDOCS}
+ @if [ ! -e ${DOCSDIR}/${x} ]; then \
+ @${ECHO_CMD} ${DOCSDIR}/${x} | \
+ ${SED} -e 's,^${PREFIX}/,,' >> ${TMPPLIST}; \
+ fi
+.endfor
The glob is expanded by the shell, so [ gets too many arguments, leading
to errors like this one:
[: /usr/local/share/doc/pyumlgraph/PyUMLGraph.css: unexpected operator
Perhaps the for-loop needs to be pushed out to the shell?
Cheers
Sam Lawrance
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1108950106.664.14.camel>