Date: Wed, 17 Dec 2014 05:58:24 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Alex Kozlov <ak@FreeBSD.org> Subject: Re: svn commit: r374800 - head/Mk/Uses Message-ID: <20141217055824.GA59186@FreeBSD.org> In-Reply-To: <5490DFDB.5080000@FreeBSD.org> References: <201412161206.sBGC6fa5045717@svn.freebsd.org> <54902709.9090801@marino.st> <71EBD6FD6D89266B6651554A@ogg.in.absolight.net> <20141216133802.GA27647@ravenloft.kiev.ua> <5B209A4BD7689CD74744CFA7@ogg.in.absolight.net> <20141216141320.GA28332@ravenloft.kiev.ua> <20141216142422.GA38033@FreeBSD.org> <5490DFDB.5080000@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 16, 2014 at 07:43:55PM -0600, Bryan Drewery wrote: > As a vendor who maintains a forked ports tree, I despise this commit and > all of the ones below. It makes carrying out customizations very > difficult. Yes, it doesn't *look* good on the eyes, but reindenting on > such large files with large history maintained by > 1 person is a sin. > > [ ... lots of commits from bapt@ WRT tabspace: 8 ... ] Agreed. I was surprised that there was no discussion on this matter at all. I know we generally had been relaxing "approve required" policies for many things, and Mk/bsd.*.mk et al. are "owned" by portmgr@, but I don't think it implies that any portmgr@ member can just come and make controversial changes like this to his liking. Lots of people work with these files, and they should've been asked. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141217055824.GA59186>