From nobody Thu Jun 12 13:31:32 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bJ3N84DGbz5ymq2; Thu, 12 Jun 2025 13:31:52 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bJ3N82PSpz3sQT; Thu, 12 Jun 2025 13:31:52 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-addcea380eeso177174466b.0; Thu, 12 Jun 2025 06:31:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749735106; x=1750339906; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Fb3QocDVA6JxSX3tmvktvU/mhfd8rstuwOmmhKks9/w=; b=a+AS44dV9XMlfQjZWPyMssP5bab89umUEdGKFpXKqXAxm86IlTPZ0tJ30Wok4MPD/V 7oiFr3JcfIfMJ/5K+Q/InPltLPrzLDyBGr0x695Mq2QwK9LKv/ZhZy24yGi1qHjAy1jS iaHdCWLfXl4wqKWtxMvFZsCveHaBoklN8YjG/olkZUq7ycF0sdOgOkZxsRPDUCXlR6kf KAgdfkoHZGueWN08RVJowVl7GcPuEUJfaG+UXRdMMpo6NtnVwttrgu3QQHjuIsbpAbZR BgNm8bF+0IS6zfCjUqTuFrJXfcSDWhgpaaPf0xFg2U2I38OfhDdrCZs0g+2IBRHGO6oR TD0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749735106; x=1750339906; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fb3QocDVA6JxSX3tmvktvU/mhfd8rstuwOmmhKks9/w=; b=VkbvRC4uIra+fKs4mLuWEk8X44gywL23+WSJC0Z7TJFPh1721g7BfiHkbROHlNoNS2 ED1iAX+tdTFlweLuz8Stxm5yM/edRYS0rUDGuzLKfmafyaT0xSYCzdW11fr0HUuSzBiD PWK1lS44/HeERf51/09NKD5dbsWayqgQAdaZJXotxZAWOmsz4tfxSQmDEK5lryrkjkE+ 9k9l7qlWHgHvw98DNnHbL2CsLM/NDGzrrCH4o0dJ5NnCxu8HBFwNtgeW9KUWFLXU3aT2 oDDy8B5dyL3gmovtDkhQhevL5RGcErLzI7WYlwxptPoLkSqUbIOCYDcqSjkU5SLEUyuz HVgA== X-Forwarded-Encrypted: i=1; AJvYcCU8lnQMjtOK0KScccSJsqZFK59Ohnz1j/zjGaCdjIfzFIwUnrXsoMhQKKS2SuOj7CdYQJo6NSSOTQCeNLS9E2potdB57A==@freebsd.org, AJvYcCUzwssdbPVr2LM3/OZZ6+d0d2HcMHqiNrtgKQ2gm579AXiiU+ln/98pIUlc2HxXTkXZRek=@freebsd.org, AJvYcCVhaJslthdtr9oOSzWF5LWSEhRCnoGCOfgxayihPopi7Q4w1gmom/HH49dO1Q1zvy7EOXxTaMhWwt9doALg9DThUehCxTQ=@freebsd.org, AJvYcCXpkK/yh6f87kQxS4WArbnuOm6NGE9jabgy0aQT/eBrSjQVzuSU1caUY6sBXDFTHPDTM5sMLkPObmdp4LAF7cw=@freebsd.org X-Gm-Message-State: AOJu0Yz6LDi8/rJXc7tEJDGycdoPXIJAhIZnasRKwbmEei18EkPtnN7k QTKWuPRYkror57fYwmReYRU3cYp1dlZ2GT/nKgFc12djlbuVtj7q4mpaaT4U34wsQGFUJ17iPsz JKAcEvxIRo7nQhF8BJrP96SrV/TW7Sak60HfP/A== X-Gm-Gg: ASbGncvvOTrdy9Kq/yx3avqKGMrOa14iMPYWzENfFC4lvecCGt1SnJ/zWfSMC+tmOzt DRkNW+ueKdXGevO/Gbh61wv801Jgi3AUFjWoNRGgzek2h9FdeAYA4nVFI1FEDjpjyw49UjaBRxB M0Ruh89hxEdteqoS6faVX1a/cS0riVz2CYmL8WEVAYeW+A1x1T769SzUPJrtKCKLsG9FZtbyr7e V+6US5HDFyF/A== X-Google-Smtp-Source: AGHT+IEer0eHegnTNLkeX1Og6Qltrlze1uw7UqFwNgaJa1DGuFIXRqIf8lOxlzje6gLz7trfFR0vD2NlN/ULDHnWrh0= X-Received: by 2002:a17:907:3e26:b0:ade:3bec:ea30 with SMTP id a640c23a62f3a-adea8d3fc34mr350333966b.1.1749735105094; Thu, 12 Jun 2025 06:31:45 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: In-Reply-To: From: Rick Macklem Date: Thu, 12 Jun 2025 06:31:32 -0700 X-Gm-Features: AX0GCFtAnWZUwpHx-hmUdNq1luCBqidHkrk4WC8MqHHfLhzwtsEg1yYNQAwjR50 Message-ID: Subject: Re: git: 79d0f4474653 - main - rpcbind: Ensure krpc is present. To: Gleb Smirnoff Cc: Konstantin Belousov , =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4bJ3N82PSpz3sQT X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] On Wed, Jun 11, 2025 at 11:19=E2=80=AFPM Gleb Smirnoff wrote: > > On Wed, Jun 11, 2025 at 07:05:45AM +0300, Konstantin Belousov wrote: > K> On Tue, Jun 10, 2025 at 08:41:44AM -0700, Gleb Smirnoff wrote: > K> > On Tue, Jun 10, 2025 at 12:11:18PM +0300, Konstantin Belousov wrote: > K> > K> Apparently we already have the feature called 'warmstart', where = rpcbind > K> > K> can be restarted and existing registrations are reloaded. So it = is in > K> > K> fact already solved, assuming admin is careful enough to use -w. > K> > > K> > Ok, then all that needs to be done is revert this: > K> > > K> > --- a/usr.sbin/rpcbind/rpcbind.c > K> > +++ b/usr.sbin/rpcbind/rpcbind.c > K> > @@ -159,10 +159,6 @@ main(int argc, char *argv[]) > K> > > K> > update_bound_sa(); > K> > > K> > - /* Ensure krpc is loaded */ > K> > - if (modfind("krpc") < 0 && kldload("krpc") < 0) > K> > - err(1, "krpc"); > K> > - > K> > /* Check that another rpcbind isn't already running. */ > K> > if ((rpcbindlockfd =3D open(RPCBINDDLOCK, O_RDONLY|O_CREAT, = 0444)) < 0) > K> > err(1, "%s", RPCBINDDLOCK); > K> Well, absolutely minimal fix would be to change err() to warn(). > > Kostik, please just commit this. Just one suggestion: make the warn() mes= sage > more verbose: > > warn("failed to load krpc module, RPC services for kernel disabled"); Yes, this sounds reasonable to me, too. rick > > -- > Gleb Smirnoff