From owner-freebsd-ports Mon Aug 2 12:13:21 1999 Delivered-To: freebsd-ports@freebsd.org Received: from dnvrpop1.dnvr.uswest.net (dnvrpop1.dnvr.uswest.net [206.196.128.3]) by hub.freebsd.org (Postfix) with SMTP id E553F14E08 for ; Mon, 2 Aug 1999 12:13:13 -0700 (PDT) (envelope-from davec@unforgettable.com) Received: (qmail 6270 invoked by alias); 2 Aug 1999 19:12:37 -0000 Delivered-To: fixup-freebsd-ports@FreeBSD.org@fixme Received: (qmail 6248 invoked by uid 0); 2 Aug 1999 19:12:36 -0000 Received: from odsl228.dnvr.uswest.net (HELO Amber.XtremeDev.com) (209.181.79.228) by dnvrpop1.dnvr.uswest.net with SMTP; 2 Aug 1999 19:12:36 -0000 From: Dave Reply-To: davec@unforgettable.com To: gj@FreeBSD.org, freebsd-ports@FreeBSD.org Subject: Re: ports/12901: New Port (slightly revised): Code Crusader and Code Medic Date: Mon, 2 Aug 1999 00:43:58 -0600 X-Mailer: KMail [version 1.0.21] Content-Type: text/plain References: <199908012036.NAA56364@freefall.freebsd.org> MIME-Version: 1.0 Message-Id: <99080201013500.75091@Amber.XtremeDev.com> Content-Transfer-Encoding: 8bit Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org > I took a look at this and it has numerous problems: > 1) it does not pass portlint Yeah it gave me warnings and no fatal errors. I corrected as many as I could, but was left with two warnings which I could not resolve, and didn't think possible to resolve. WARN: "MASTER_SITES" has to appear earlier in Makefile. WARN: "DISTFILES" has to appear earlier in Makefile. These were refering to the MASTER_SITES += and DISTFILES += within the if statement for Code Medic. Should the user choose not to compile the gdb frontend with Code Crusader, these two lines would not be executed. Unless there's a better method? > 2) one of the files (JX_source-1.5.2.tar.gz, I think it was) has a > different checksum now This was a new change after I had submitted the port. I had done a make distclean and make reinstall before I submitted the port. It's corrected now, and the checksum is updated. Sorry about that. > 3) patch-aa and patch-ac did not apply correctly patch-aa has been updated and works now. However I did not touch patch-ac, and it applied successfully without problems here after a make distclean; make patch. > 4) patch-aa has /usr/local hard coded into it, should be $PREFIX > after correcting these problems locally jcc core dumps. I also noticed > that a $PREFIX/bin/ctags gets installed. This conflicts with the > standard /usr/bin/ctags. Hmm. I had not realize ctags came install with FreeBSD. I've now taken it out of the Code Crusader compile. And is submitting another send-pr. I haven't had jcc core dumped on me yet, and I've been using it since April on 4.0-CURRENT. Could you try the new shar archive and let me know what happens? > Please try to correct these problems and resubmit the port. > > Thanks for your effort ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message