Date: Tue, 2 Jun 2015 09:18:17 +0000 From: "andrew (Andrew Turner)" <phabric-noreply@FreeBSD.org> To: freebsd-arm@freebsd.org Subject: [Differential] [Updated] D2701: Add options to dmb() and dsb() macros Message-ID: <f73c7bb9fb5e0a6fdaabef0310ab0925@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-kl3ls7rde2bkjzreqxfo-req@FreeBSD.org> References: <differential-rev-PHID-DREV-kl3ls7rde2bkjzreqxfo-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
andrew added a comment. Given you are changing these can you also mark them as with `ish*`? INLINE COMMENTS sys/arm64/arm64/db_interface.c:164-165 Are these needed? The cache handling functions already have dsb and isb instructions. sys/arm64/include/atomic.h:32 This should be `#define<tab>isb()...` sys/arm64/include/atomic.h:49-54 And these REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D2701 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: zbb, emaste, imp, ian, andrew Cc: emaste, andrew, imp, freebsd-arm
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f73c7bb9fb5e0a6fdaabef0310ab0925>