From owner-freebsd-ports@FreeBSD.ORG  Thu Feb  7 23:50:33 2013
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 56AB6569;
 Thu,  7 Feb 2013 23:50:33 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (tensor.andric.com
 [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26])
 by mx1.freebsd.org (Postfix) with ESMTP id 1A9B981E;
 Thu,  7 Feb 2013 23:50:33 +0000 (UTC)
Received: from [192.168.0.6] (spaceball.home.andric.com [192.168.0.6])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by tensor.andric.com (Postfix) with ESMTPSA id 3522D5C43;
 Fri,  8 Feb 2013 00:50:32 +0100 (CET)
Message-ID: <51143DC7.7070902@FreeBSD.org>
Date: Fri, 08 Feb 2013 00:50:31 +0100
From: Dimitry Andric <dim@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:19.0) Gecko/20130117 Thunderbird/19.0
MIME-Version: 1.0
To: Dewayne Geraghty <dewayne.geraghty@heuristicsystems.com.au>
Subject: Re: openssh-portable segmentation faults
References: <67A39057348F4D1BA43004DB5F0E8DBB@white>
 <5113B343.303@FreeBSD.org> <CD64A9A7097A415CB05541C9032576D1@white>
 <511435D8.8000900@FreeBSD.org>
In-Reply-To: <511435D8.8000900@FreeBSD.org>
Content-Type: multipart/mixed; boundary="------------040008010600050902050706"
Cc: ports@FreeBSD.org, Brooks Davis <brooks@freebsd.org>,
 Bryan Drewery <bdrewery@FreeBSD.org>
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Feb 2013 23:50:33 -0000

This is a multi-part message in MIME format.
--------------040008010600050902050706
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 2013-02-08 00:16, Dimitry Andric wrote:
> On 2013-02-07 22:14, Dewayne Geraghty wrote:
> ...
>> Bryan, Dimitry,
>> Thank-you for your interest.
>> Unfortunately we have no debugging tools on any of the machines. I'll build one today and reproduce.
...
> Executive summary: we recently imported a strnvis() implementation from
> NetBSD, which has differently ordered arguments from the strnvis()
> implementation in OpenBSD.  When OpenSSH calls it with arguments ordered
> in the way OpenBSD expects, the function segfaults.

And here is a patch, which works for me.  It simply disables use of
libc's strnvis(), forcing the port to use its own bundled version.

--------------040008010600050902050706
Content-Type: text/x-diff;
 name="security__openssh-portable-1.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="security__openssh-portable-1.diff"

Index: security/openssh-portable/Makefile
===================================================================
--- security/openssh-portable/Makefile	(revision 311824)
+++ security/openssh-portable/Makefile	(working copy)
@@ -25,6 +25,7 @@ CONFLICTS?=		openssh-3.* ssh-1.* ssh2-3.*
 USE_PERL5_BUILD=	yes
 USE_OPENSSL=		yes
 GNU_CONFIGURE=		yes
+CONFIGURE_ENV=		ac_cv_func_strnvis=no
 CONFIGURE_ARGS=		--prefix=${PREFIX} --with-md5-passwords \
 			--without-zlib-version-check --with-ssl-engine
 PRECIOUS=		ssh_config sshd_config ssh_host_key ssh_host_key.pub \

--------------040008010600050902050706--