From nobody Mon Nov 24 03:59:46 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dFBsz3t9Kz6HytC for ; Mon, 24 Nov 2025 03:59:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dFBst2kcvz3Xv5 for ; Mon, 24 Nov 2025 03:59:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763956786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xxiobMs06Gb3+ngOcayuSj3Y2WaADEHRPQnXitGuVM4=; b=jz1iVfFIDcIeGjnvW3XB4ZglYaIbE50PNCe1+aYqjTuGJ6wDvkL5IbSjpEVoKfqoMvpvBo L3f5d8CsQmy7d2qPRgliwelL0jvXk+1FwLwMtj0drwLPdXkPVvbfdHv8AFDnZdltIzhiS6 XXbsLy81O4+mq1Es4p3VvxjQi0PkMqSm66puuQDYcQAOLAe7Jcxwb/3C9hRxBu1g4J29v3 DK5ddE6N/yywZGPFjIYb0zrlHPneG/phoQhvI/udGFlFlGXk7HCfc0NpDBxztFagtwtSWH NQh+e+6ncTRRa623E31maR2QZ1Rs3yy4gtFmihNKgcGS/Wqc/OK5ZF95d5VAyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763956786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xxiobMs06Gb3+ngOcayuSj3Y2WaADEHRPQnXitGuVM4=; b=Xmx3WV2fRjTLWYRSCP+FVAE3m+M/GeD1itK78qZzPLiXdIcbwEEfQIe7zgjahOOKzbW5V4 lZCjuV5BDOyW6seSvZxaaGbxyI8eIqbmvtRe+7PhOsl7ItB5xqNb8rf7nAAXWrkSftKNRj qiGOcIKS8hjHMgHekriKtpoKtjqDn/i7XbtG/GP/WlPlzDoXgzpGi6kLldYGpEahhGpqCd B3Irl1cBxGwa/VA1SzktXU4d1TKoEIWC3x5qoHXRRRXsDFG3r97ZRc4sujkrg5k9WT3XCj PX4jjMgukpalWSAZXNrxtjVvkOO+zk3H1kWzkKGnk1iU59IokdS+SW0a6WzcqQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763956786; a=rsa-sha256; cv=none; b=aJIUyY1epQUNqanBf904IfX33likrxxMWCZUNv2pilQ0B8oBzKCIf36gZBlxivdzY0Zrhf pNXflocmx/MlfHNb0JD6c/MqoaLbHi+Nl7G1WdQLkGUFKdrTJeYHm3GX/slyhGky/kGGap AWInsBl0gmfepdDKTD0Aptwqq81ms1a5nY6xw5f4nLGXHQtX1zDqwO+bGnmzJ9KsWvh6g+ FoCGQe54CU8Xh9PAUYwALz+7txym+W6YI766JkzJrSqNuBvpidPtnJ+4ylEi7c4UQo5M8C FMHT2I49Si56XfMPHkyep5tl41z1xkTQqV+8Ik0yCvgolAhHuyWHcOho25UmNA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dFBst28Zvzy8w for ; Mon, 24 Nov 2025 03:59:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3389a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 24 Nov 2025 03:59:46 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Cy Schubert Subject: git: 383ad19726a8 - stable/15 - ntpd: Fix segfault when same IP on multiple interfaces List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 383ad19726a8778b9ed7440ea917253366c3a811 Auto-Submitted: auto-generated Date: Mon, 24 Nov 2025 03:59:46 +0000 Message-Id: <6923d832.3389a.72364595@gitrepo.freebsd.org> The branch stable/15 has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=383ad19726a8778b9ed7440ea917253366c3a811 commit 383ad19726a8778b9ed7440ea917253366c3a811 Author: Cy Schubert AuthorDate: 2025-11-21 00:16:04 +0000 Commit: Cy Schubert CommitDate: 2025-11-24 03:59:36 +0000 ntpd: Fix segfault when same IP on multiple interfaces Use the protype socket to obtain the IP address for an error message. Using the resultant socket address, a NULL because create_interface() had failed, results in SIGSEGV. To reproduce this bug, ifconfig bridge100 create ifconfig bridge100 10.10.10.10/24 ifconfig bridge101 create ifconfig bridge101 10.10.10.10/24 ntpd -n PR: 291119 MFC after: 3 days (cherry picked from commit ac1f48b4a7be104d222dea60f1da946fcb345fb1) --- contrib/ntp/ntpd/ntp_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/ntp/ntpd/ntp_io.c b/contrib/ntp/ntpd/ntp_io.c index 9c4f6c1553e3..97b85ee83e36 100644 --- a/contrib/ntp/ntpd/ntp_io.c +++ b/contrib/ntp/ntpd/ntp_io.c @@ -1923,7 +1923,7 @@ update_interfaces( msyslog(LOG_ERR, "cannot bind address %s", - stoa(&ep->sin)); + stoa(&ep2->sin)); } free(ep2); }