From owner-svn-src-head@freebsd.org Fri Dec 2 16:00:14 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B5BEAC63D8D; Fri, 2 Dec 2016 16:00:14 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vps1.elischer.org", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 731941CF2; Fri, 2 Dec 2016 16:00:14 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from Julian-MBP3.local (ppp121-45-230-194.lns20.per1.internode.on.net [121.45.230.194]) (authenticated bits=0) by vps1.elischer.org (8.15.2/8.15.2) with ESMTPSA id uB2G07m9072144 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 2 Dec 2016 08:00:10 -0800 (PST) (envelope-from julian@freebsd.org) Subject: Re: svn commit: r309035 - in head/lib/libpathconv: . tests To: Jilles Tjoelker References: <201611230757.uAN7vqmC008888@repo.freebsd.org> <20161127204305.GA58954@stack.nl> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Julian Elischer Message-ID: <4de52b2a-fef9-f043-2409-c77bafc599fe@freebsd.org> Date: Sat, 3 Dec 2016 00:00:01 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <20161127204305.GA58954@stack.nl> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2016 16:00:14 -0000 On 28/11/2016 4:43 AM, Jilles Tjoelker wrote: > On Wed, Nov 23, 2016 at 07:57:52AM +0000, Julian Elischer wrote: >> Author: julian >> Date: Wed Nov 23 07:57:52 2016 >> New Revision: 309035 >> URL: https://svnweb.freebsd.org/changeset/base/309035 >> Log: >> This little BSD licensed library has been kicking around for years. >> It allows one to trivially convert an absolute path to a relative path >> and the reverse. The test programs themselves are very useful in scripts >> but the real use comes shortly with the -r and -a arguments to ln. >> These are sometimes known as the --relative and --absolute flags and >> can force a symlink to be relative when you only have an absolue path. >> Another place these are sometimes used is to add -a and -r args to 'realpath'. >> Incredibly useful in Makefiles. >> I was going to just add the files in with 'ln' but a library makes more sense. >> The test programs may come out in their own right some day for scripting. >> released under a BSD 2-clause: >> * Copyright (c) 1997 Shigio Yamaguchi. All rights reserved. >> * Copyright (c) 1999 Tama Communications Corporation. All rights reserved. >> The test directry does not conform to any framework. >> Not connected to build. >> doc people may want to play with the manual pages. >> Obtained from: https://www.tamacom.com/pathconvert.html Shigio Yamaguchi. >> MFC after: 1 month >> Relnotes: yes >> Sponsored by: Panzura, Tama Communications Corporation > Consider making this a static-only library or a part of an existing > library such as libc or libutil, since the overhead of a shared object > is rather big compared to the amount of code here. yeah I was thinking of making it part of libc but libc is already such a kitchen sink and there are only two planned users. ln and realpath. A static library is one idea for sure. (or even just a .o). The actual real target for this is the build itself. Currently we are making lots of symlinks that should be relative but we only really have absolute information. This allows symlink -sr to dynamically generate the correct relative symlink, given absolute args. e.g. /usr/lib/libm.so -> /lib/libm.so.5 should really be ../../lib/libm.so.5 so that when it is read from outside a jail it still refers to the right place. I'm waiting for a gap in my work schedule to get ln and realpath changes in place. > > Thanks for not linking this to the build right away. >