From owner-svn-src-all@freebsd.org Fri Feb 19 00:02:16 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6C22EAACD84 for ; Fri, 19 Feb 2016 00:02:16 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F1091616 for ; Fri, 19 Feb 2016 00:02:15 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: by mail-wm0-x230.google.com with SMTP id g62so48691544wme.0 for ; Thu, 18 Feb 2016 16:02:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sippysoft-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=UMYTqcHrYEZ0vulF2k8uBBTLqmrhONgiLQBueOmrLHk=; b=j4xdjd72KxdEI0VqJ9L45t3gARV8/3+WHkLmtEYXtI+FXUbEYw/6tjPO1uoAi0rJdg gYbw7mexrmH03qX1Pq26JVXqxsmHV9X+ALFKPbKDMzHZwMr1iGPgxF9D85CUsXjJjUdT uuhcRxPejZUsS8KB1/jH0Z1E/WF7B1H6UFzOFhTsHUjNCmCiWvBV3qHtlRA6EYN1FxNy 5WROgdmWa84eI2UCcneP9MZJOaKuVN1903Oak6M4kn5wMKPrjObUVMQoXIoxZ7CXBfPX bb3sd2ut04XFZNAzXRsZW8CswifkBjSlTqGaCuO6705T7BSy45m4CWyl/pNi+koIo0kD 9shw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=UMYTqcHrYEZ0vulF2k8uBBTLqmrhONgiLQBueOmrLHk=; b=DmNtZYjcX+D8l9qAebjBWCQsclrwKzfYLeHc3hNaQkrscWHKYQRyn5l6/zIqmh9wR8 9Lh0DLnACcJGGXGdi2rcDL+1y4N4cjpqWNMKD198AXkyep34YfLctyWVJ+/vWkIuI33M C+t3pvb6O79zEcdYSZjF/EQTiBHP6NbH5oBVJuFKqVHvWD62VVjWXtZBDg9+XqNRvlLd y2Wp+jH4+6OEY2y01FwZDFzrF67oFkTnLW/+KtA/q120NNz+UkJlQsUaD3gXijIbj68n x4XR1iDVzAk4Uo/Qv59AWKRO1zx1rU4M5m6rSHARvY/9ZE2j4Zxu0zz9CssPWhWCCOha Y1cQ== X-Gm-Message-State: AG10YORXAQvJIkRu5T1xetGhNK4qdA9oHe2nRyI8otaOjVGd2qw5tPxoYTyOOZ7djLqn8L7ndfWozWGyqBh2beK9 MIME-Version: 1.0 X-Received: by 10.28.61.70 with SMTP id k67mr6049702wma.90.1455840134521; Thu, 18 Feb 2016 16:02:14 -0800 (PST) Sender: sobomax@sippysoft.com Received: by 10.27.218.12 with HTTP; Thu, 18 Feb 2016 16:02:14 -0800 (PST) In-Reply-To: References: Date: Thu, 18 Feb 2016 16:02:14 -0800 X-Google-Sender-Auth: yFh2b4MI8VMw3a-2El0Q__y56b8 Message-ID: Subject: Re: svn commit: r229537 - in head/sys: conf geom/uncompress modules/geom/geom_uncompress From: Maxim Sobolev To: ray@freebsd.org, Adrian Chadd Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2016 00:02:16 -0000 And also geom_uncompress(4) lists myself as a primary historical author of the kernel module code, which I think just plain confusion between my name and name of Max Khon, who is the original creator of geom_uzip(4). It's further reiterates the need to clean this up properly, so only the code with longer history survives. On Thu, Feb 18, 2016 at 3:57 PM, Maxim Sobolev wrote: > Aleksandr, Adrian, > > I know it's 3 years later, but I really don't know why it's been done this > way. Take a GEOM module and associated usr.bin utility, copy it verbatim > add few lines of code and re-add that as a new module seems like just > laziness and attempt to avoid doing extra work on making unified code. The > same goes for the mkulzma, which is almost 1:1 copy of the mkuzip. Now > people are merging back and forth and I've just spent few days testing some > rather major rework of geom_uzip / mkuzip code not even realizing that > there is its evil twin in the tree. :( > > https://reviews.freebsd.org/D5333 > > I suggest functionality from both geom_uncompress / mkulzma are folded now > back into geom_uzip / mkuzip and geom_uncompress / mkulzma are nuked > afterwards. > > Thanks! > > > >> Author: ray >> Date: Wed Jan 4 23:39:11 2012 >> New Revision: 229537 >> URL: http://svn.freebsd.org/changeset/base/229537 >> Log: >> GEOM_UNCOMPRESS module, can be used with uzip images and with new ulzma >> images. >> Approved by: adrian (mentor) >> Added: >> head/sys/geom/uncompress/ >> head/sys/geom/uncompress/g_uncompress.c (contents, props changed) >> head/sys/modules/geom/geom_uncompress/ >> head/sys/modules/geom/geom_uncompress/Makefile (contents, props changed) >> Modified: >> head/sys/conf/files >> head/sys/conf/options > > >