From owner-freebsd-stable@FreeBSD.ORG Tue Jul 18 06:42:13 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B573216A4E6 for ; Tue, 18 Jul 2006 06:42:13 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from nz-out-0102.google.com (nz-out-0102.google.com [64.233.162.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id 708A143D4C for ; Tue, 18 Jul 2006 06:42:12 +0000 (GMT) (envelope-from pyunyh@gmail.com) Received: by nz-out-0102.google.com with SMTP id f1so547881nzc for ; Mon, 17 Jul 2006 23:42:11 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=Gxd9iryd+hxZNS/3xDr2ymjay3zrpr/qUNo3AlrWVs3A8RMYyZxcZMAQ0IgMCQM4A0BCNz7zDDpqQuwoobs6RHnN20plODLF0A3XDBRzuWt8k9MYu1o6jlVUlzB2Qofp0ooUKTpvjZk8yS82+z8H2XbDs35ei2uug97ZvnwQ54U= Received: by 10.36.133.19 with SMTP id g19mr3629176nzd; Mon, 17 Jul 2006 23:42:11 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.gmail.com with ESMTP id 18sm295455nzo.2006.07.17.23.42.08; Mon, 17 Jul 2006 23:42:11 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id k6I6hoPX034792 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 18 Jul 2006 15:43:50 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id k6I6hgQV034790; Tue, 18 Jul 2006 15:43:42 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Tue, 18 Jul 2006 15:43:41 +0900 From: Pyun YongHyeon To: Atanas Message-ID: <20060718064341.GC33301@cdnetworks.co.kr> References: <44AD7297.7080605@asd.aplus.net> <20060707010341.GD82406@cdnetworks.co.kr> <44ADC2ED.4070904@asd.aplus.net> <20060707040838.GE82406@cdnetworks.co.kr> <20060707151640.D51390@fledge.watson.org> <44AEB0CB.5060102@asd.aplus.net> <20060707181750.O1171@ganymede.hub.org> <20060707223609.N60542@fledge.watson.org> <20060708033254.GB87930@cdnetworks.co.kr> <44B2BCDB.7050403@asd.aplus.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44B2BCDB.7050403@asd.aplus.net> User-Agent: Mutt/1.4.2.1i Cc: Peter Jeremy , Robert Watson , Michael Vince , freebsd-stable@freebsd.org, User Freebsd Subject: Re: em device hangs on ifconfig alias ... X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jul 2006 06:42:13 -0000 On Mon, Jul 10, 2006 at 01:47:23PM -0700, Atanas wrote: > Pyun YongHyeon said the following on 7/7/06 8:32 PM: > >On Fri, Jul 07, 2006 at 10:38:01PM +0100, Robert Watson wrote: > > > > > > Yes -- basically, there are two problems: > > > > > > (1) A little problem, in which an arp announcement is sent before the > > link > has > > > settled after reset. > > > > > > (2) A big problem, in which the interface is gratuitously recent > > requiring > > > long settling times. > > > > > > I'd really like to see a fix to the second of these problems (not > > resetting > when an IP is added or removed, resulting in link > > renegotiation); the first > one I'm less concerned about, although it > > would make some amount of sense > to do an arp announcement when the link > > goes up. > > > > > > >Ah, I see. Thanks for the insight. > >How about the attached patch? > > > This patch seems to fix both of the issues, or at least this is what I > see now: > - the card no longer gets reset when adding an alias; > - the arp packet gets delivered; > - adding 250 aliases takes less than a second; > > I haven't fully tested whether all 250 IP aliases were accessible (I > used non-routable IP addresses), but I suppose so. Also I couldn't > stress the patched driver enough to see whether it performs as expected. > > But in overall it looks good. I guess some more testing might be needed > in order to merge the patch into the source tree. > I haven't received any reports execept this one. If there is no objection I'll commit these changes within two days. -- Regards, Pyun YongHyeon