From owner-freebsd-current Sun Jan 20 11:31:36 2002 Delivered-To: freebsd-current@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id E16EB37B435; Sun, 20 Jan 2002 11:31:24 -0800 (PST) Received: (from ache@localhost) by nagual.pp.ru (8.11.6/8.11.6) id g0KJVNm23986; Sun, 20 Jan 2002 22:31:23 +0300 (MSK) (envelope-from ache) Date: Sun, 20 Jan 2002 22:31:21 +0300 From: "Andrey A. Chernov" To: markm@freebsd.org, des@freebsd.org, current@freebsd.org Subject: Step3, pam_opie snprintf bloat fix for review Message-ID: <20020120193121.GA23954@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.3.24i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Bug: snprintf is large and slow, increasing program size and slowing it down. Better way is avoid snprintf when it is not neccessary. Fix: Full functionality of snprintf is not needed below, so it is replaced by much faster strlcpy. --- pam_opie.c.bak Sat Jan 19 21:29:49 2002 +++ pam_opie.c Sun Jan 20 22:23:18 2002 @@ -125,7 +125,7 @@ } /* We have to copy the response, because opieverify mucks with it. */ - snprintf(resp, sizeof resp, "%s", response); + strlcpy(resp, response, sizeof resp); /* * Opieverify is supposed to return -1 only if an error occurs. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message