From owner-svn-src-head@freebsd.org Thu Apr 20 18:06:11 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 14436D480E9; Thu, 20 Apr 2017 18:06:11 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) by mx1.freebsd.org (Postfix) with ESMTP id 707A21698; Thu, 20 Apr 2017 18:06:10 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Subject: Re: svn commit: r317171 - head/sys/dev/vt To: Ed Maste Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" References: <201704192221.v3JMLFPs032866@repo.freebsd.org> From: Jung-uk Kim Message-ID: Date: Thu, 20 Apr 2017 14:06:05 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="D0KmnD46FDVDbQwhX8VS1ukwMSaGJh2TI" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2017 18:06:11 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --D0KmnD46FDVDbQwhX8VS1ukwMSaGJh2TI Content-Type: multipart/mixed; boundary="jf1OklO0u8PlVmebFFV2M1uGAAfLQrsTc"; protected-headers="v1" From: Jung-uk Kim To: Ed Maste Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-ID: Subject: Re: svn commit: r317171 - head/sys/dev/vt References: <201704192221.v3JMLFPs032866@repo.freebsd.org> In-Reply-To: --jf1OklO0u8PlVmebFFV2M1uGAAfLQrsTc Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable On 04/19/2017 22:22, Ed Maste wrote: > On 19 April 2017 at 18:21, Jung-uk Kim wrote: >> Author: jkim >> Date: Wed Apr 19 22:21:15 2017 >> New Revision: 317171 >> URL: https://svnweb.freebsd.org/changeset/base/317171 >> >> Log: >> Micro-optimize vt_set_border(). >=20 > I expect we'll eventually have vt drivers that have a non-trivial > vd_drawrect, making the previous implementation preferable. Can you > comment a bit more on this change? Maybe but I haven't seen much improvement in the area for many years. Do you have any reason to believe someone is working on it? Even if we have such backend, I don't expect much difference in drawing small area, i.e., redrawing narrow borders. On top of that, I don't like "if (vd->vd_driver->vd_drawrect =3D=3D NULL) return (ENOTSUP)" stuff= =2E Jung-uk Kim --jf1OklO0u8PlVmebFFV2M1uGAAfLQrsTc-- --D0KmnD46FDVDbQwhX8VS1ukwMSaGJh2TI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEl1bqgKaRyqfWXu/CfJ+WJvzb8UYFAlj4+JEACgkQfJ+WJvzb 8UZoagf/TKXZZ6KWkbrn10rmyHg8P/F8ZkrKoSf3vG8LqG97VnqzQOrf5hyHvsm8 LjmYLjHAAwpQ85rcxb57YIwPNMMmz4KaP5C5ys8hVtLUq42umeTTwokHlQAQCQMu y7D8V4C8ehZY5pZj5uzowdXWdcPJrs/8V8tSydbBCYTI0YDKFynhHqjcvlhWuh2x 7Ro9z5EO09OjA3JkMGW+SWbshpqBpxO69c9gO7wba5/VkLSsJ1mGgmEGDizbvhxJ Vib67EMw1yMf90AElqIQNDLfyzvNBkk/kiYEFZfT46ULxOsmBV6rNzhM0/o1qOeN H5bj7W6p8tn1DLVkb4V0vemMi8fr5w== =IDVM -----END PGP SIGNATURE----- --D0KmnD46FDVDbQwhX8VS1ukwMSaGJh2TI--