From owner-freebsd-geom@FreeBSD.ORG Fri Sep 5 07:35:22 2008 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E67721065673 for ; Fri, 5 Sep 2008 07:35:22 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello087206045140.chello.pl [87.206.45.140]) by mx1.freebsd.org (Postfix) with ESMTP id 49DC18FC16 for ; Fri, 5 Sep 2008 07:35:22 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id A4B7945C89; Fri, 5 Sep 2008 09:35:19 +0200 (CEST) Received: from localhost (unknown [10.0.1.11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id B2AE14569A; Fri, 5 Sep 2008 09:35:14 +0200 (CEST) Date: Fri, 5 Sep 2008 09:35:17 +0200 From: Pawel Jakub Dawidek To: Pete French Message-ID: <20080905073517.GA4021@garage.freebsd.pl> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1yeeQ81UyVL57Vl7" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: freebsd-geom@freebsd.org Subject: Re: Could someone take a look at a small patch to gmirror ? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Sep 2008 07:35:23 -0000 --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 04, 2008 at 04:59:09PM +0100, Pete French wrote: > Hi, I was told on -stable that I might get more luck here regarding a > patch I wrote to gmirror a while ago. It simply adds a new balacing > algorithm called 'prefer-low' which does the reverse to 'prefer' - i.e. > will always read from the disc with the lowest priority, not the highest. > I also moved the default priority to the centre of the range, so that dri= ves > can be added to a mirror with a lower or higher priority than the origina= l. >=20 > I submitted this as PR in May here: > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D123630 >=20 > I have been using this patch live on our database servers since then > and it works fine. I have stress tested it as much as I can, and was hopi= ng > that someone else might like to take a look, give a bit of testing and > commit it. The patch includes manpage changes as well as code changes, > it was written relative to stable at the time, but patches against 7.1 > prerelease cleanly as well. I was hopinh it might make it into 7.1, but > maybe it is a bit too late for that. >=20 > Anyway, I hope someone can take a look The possibility of setting priority only on insert time is a bit limiting (and mentioned in BUGS section in gmirror(8)), but I think the better way to do it is to just extend configure subcommand to allow priority change, eg. # gmirror label foo da0 da1 # gmirror configure -p 7 foo da1 We could also add -p option to label subcommand to define starting priority, but I'm not sure about that one. Would you like to work on such a patch maybe? --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFIwOE0ForvXbEpPzQRAr/8AJ4hGs0juka37UUhSy+nJAl5U9vUcQCg7CXX vh2Ak3uxcYGLhR6tBACHGZ4= =9XgY -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7--