From owner-freebsd-arch@FreeBSD.ORG  Wed Dec 13 23:31:36 2006
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
X-Original-To: freebsd-arch@freebsd.org
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id B800A16A49E;
	Wed, 13 Dec 2006 23:31:36 +0000 (UTC) (envelope-from jdp@polstra.com)
Received: from blake.polstra.com (blake.polstra.com [64.81.189.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4DB3043DA2;
	Wed, 13 Dec 2006 23:29:21 +0000 (GMT) (envelope-from jdp@polstra.com)
Received: from strings.polstra.com (strings.polstra.com [64.81.189.67])
	by blake.polstra.com (8.13.8/8.13.8) with ESMTP id kBDNUpLK005011;
	Wed, 13 Dec 2006 15:30:52 -0800 (PST) (envelope-from jdp@polstra.com)
Message-ID: <XFMail.20061213153051.jdp@polstra.com>
X-Mailer: XFMail 1.5.5 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <200612121509.03785.jhb@freebsd.org>
Date: Wed, 13 Dec 2006 15:30:51 -0800 (PST)
From: John Polstra <jdp@polstra.com>
To: John Baldwin <jhb@freebsd.org>
Cc: freebsd-arch@freebsd.org
Subject: Re: Where do MSI quirks belong? [patch]
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Dec 2006 23:31:36 -0000

On 12-Dec-2006 John Baldwin wrote:

> Updated patch (relative to the stuff I just committed) is at the
> same location:
> 
> http://www.FreeBSD.org/~jhb/patches/msi_blacklist.patch
> 
> Can you review and possibly test it?

I reviewed the patch, and it looks fine except for two minor
style mismatches.  The definitions of PCI_QUIRK_DISABLE_MSI and
PCIB_DISABLE_MSI both have a tab after the #define, but in each case
the preceding line used a space after the #define.  Hang your head
in shame! ;-)

I'm updating a system to the latest -current so I can test the
patch.  I'll report back soon.

John