Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 12 Feb 2025 19:34:31 GMT
From:      John Baldwin <jhb@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: f42f7bedabb3 - main - ctld: Fail for missing or invalid CHAP secrets in UCL config
Message-ID:  <202502121934.51CJYV04059834@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by jhb:

URL: https://cgit.FreeBSD.org/src/commit/?id=f42f7bedabb329b68c7c9aa0d9a2dc49637d385f

commit f42f7bedabb329b68c7c9aa0d9a2dc49637d385f
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2025-02-12 19:27:06 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2025-02-12 19:27:06 +0000

    ctld: Fail for missing or invalid CHAP secrets in UCL config
    
    Reviewed by:    asomers
    Sponsored by:   Chelsio Communications
    Differential Revision:  https://reviews.freebsd.org/D48931
---
 usr.sbin/ctld/uclparse.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/usr.sbin/ctld/uclparse.c b/usr.sbin/ctld/uclparse.c
index bd3c90283f6d..8654004d009e 100644
--- a/usr.sbin/ctld/uclparse.c
+++ b/usr.sbin/ctld/uclparse.c
@@ -73,6 +73,7 @@ uclparse_chap(struct auth_group *auth_group, const ucl_object_t *obj)
 	if (!secret || secret->type != UCL_STRING) {
 		log_warnx("chap section in auth-group \"%s\" is missing "
 		    "\"secret\" string key", auth_group->ag_name);
+		return (false);
 	}
 
 	ca = auth_new_chap(auth_group,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202502121934.51CJYV04059834>