From owner-svn-src-head@freebsd.org  Wed Jul  4 19:46:24 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2A75A1034793;
 Wed,  4 Jul 2018 19:46:24 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A108E704FA;
 Wed,  4 Jul 2018 19:46:23 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w64JkKi1044530;
 Wed, 4 Jul 2018 12:46:20 -0700 (PDT)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w64JkKHM044529;
 Wed, 4 Jul 2018 12:46:20 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201807041946.w64JkKHM044529@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r335967 - head/sys/dev/mxge
In-Reply-To: <201807041929.w64JT67O091471@repo.freebsd.org>
To: Andrew Gallatin <gallatin@freebsd.org>
Date: Wed, 4 Jul 2018 12:46:20 -0700 (PDT)
CC: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jul 2018 19:46:24 -0000

> Author: gallatin
> Date: Wed Jul  4 19:29:06 2018
> New Revision: 335967
> URL: https://svnweb.freebsd.org/changeset/base/335967
> 
> Log:
>   mxge: choose appropriate values for hw tso
> 
> Modified:
>   head/sys/dev/mxge/if_mxge.c
> 
> Modified: head/sys/dev/mxge/if_mxge.c
> ==============================================================================
> --- head/sys/dev/mxge/if_mxge.c	Wed Jul  4 18:54:44 2018	(r335966)
> +++ head/sys/dev/mxge/if_mxge.c	Wed Jul  4 19:29:06 2018	(r335967)
> @@ -4984,6 +4984,9 @@ mxge_attach(device_t dev)
>  	ifp->if_ioctl = mxge_ioctl;
>  	ifp->if_start = mxge_start;
>  	ifp->if_get_counter = mxge_get_counter;
> +	ifp->if_hw_tsomax = 65536 - (ETHER_HDR_LEN + ETHER_VLAN_ENCAP_LEN);

Would not this be more accurate (need to reorder assigns):
	ifp->if_hw_tsomax = ifp->if_hw_tsomaxsegsize - (ETHER_HDR_LEN + ETHER_VLAN_ENCAP_LEN);

> +	ifp->if_hw_tsomaxsegcount = sc->ss[0].tx.max_desc;
> +	ifp->if_hw_tsomaxsegsize = 65536;


>  	/* Initialise the ifmedia structure */
>  	ifmedia_init(&sc->media, 0, mxge_media_change,
>  		     mxge_media_status);
> 
> 

-- 
Rod Grimes                                                 rgrimes@freebsd.org