From owner-svn-src-all@freebsd.org Tue Feb 26 17:18:57 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9E5CC151FCDA for ; Tue, 26 Feb 2019 17:18:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 317658F08E for ; Tue, 26 Feb 2019 17:18:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x830.google.com with SMTP id p48so15800079qtk.2 for ; Tue, 26 Feb 2019 09:18:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SWi+qUsT/yOna7Rv2qpM2sUsnri/Gp4dSzJ6uoGU+Hw=; b=k2l7X02kBm3kANSADMnjGVjfTtPYB6wqBWVw8yPlqxWhbKnxH2PQcLWSzixcVSwrOv wKTFzyiiRyguykX4Pb5J4lm5zWC1imkSK+h4arpbGagrTht7FnLjhBSb4dtJZer96rZ9 2Ch1/7zZ3D6SRTdA+L5UHQXpGvh8A31XMlPoeTqrlilS8j/lvLttIyAYGkEGznLQVTFj MFt7bpq4qB2QlZPNKOTEqe/RLvaN49A8rYxyQQ5JrhameO9T4PMWczgW8mkXx+lvVGQZ pSLGTZIk27+VfQiB7KrZPe57NTdLzsZkuRMlJTyiId6dey/fyKOOBXnqUfts5ws4sjZr Jp+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SWi+qUsT/yOna7Rv2qpM2sUsnri/Gp4dSzJ6uoGU+Hw=; b=Kmjn/iw6r33KTq3a0aalXQqWT9fGLEokIoOpccOIp55q/RJtYulhTXHbvckccQu/6n wLBVl2DT0U6R6/2st3gJ6JvmKWGtfTT5/4ZlXHb9ilobppfqAmZRVnsmI/pyAM9PWmpG S2GHDpIiPTZ69lrASwGuzAxUfhD3b0em2lzNlzXDbmbw5bHm3aizRVca+aaYWWyydjYv gNz+IL4s+jwv9HJQJRLw7kRKD+iAR53yGHDv2lJqwA4OoLCHeSPIqWmn1csEFNmyj88I bpwb83QZjvfSsRbbVN/8cli/b+AbJCoJhvE1I+gceo913Zz2kLvHUE9HCJJyTZK3zwod yi9w== X-Gm-Message-State: AHQUAuaG9vEPQ25Mi3SDfwx6oqMYWsnbV8L6RWEvRH6quvFFwK01gvVY EjpbNABO7ZyY/ubTkRKPToi8ig83YMMHV5vR9KhnGg== X-Google-Smtp-Source: AHgI3IaM0f5So9OCto/FPei9njkT/M1RoV76By3Mff7kF5unyZ32EJHNCNhJ0A/XKwCQTVjO864d9PDXnBYGF/azSz8= X-Received: by 2002:ac8:16d0:: with SMTP id y16mr18249762qtk.345.1551201536550; Tue, 26 Feb 2019 09:18:56 -0800 (PST) MIME-Version: 1.0 References: <201902260218.x1Q2Ig4r042692@pdx.rh.CN85.dnsmgr.net> <20190226154535.q32nwf6xyupexkta@mutt-hbsd> In-Reply-To: <20190226154535.q32nwf6xyupexkta@mutt-hbsd> From: Warner Losh Date: Tue, 26 Feb 2019 10:18:45 -0700 Message-ID: Subject: Re: svn commit: r344487 - in head/sys: conf gnu/gcov To: Shawn Webb Cc: "Rodney W. Grimes" , "K. Macy" , svn-src-head@freebsd.org, Matt Macy , svn-src-all@freebsd.org, Brooks Davis , src-committers X-Rspamd-Queue-Id: 317658F08E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.992,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 17:18:58 -0000 On Tue, Feb 26, 2019 at 8:46 AM Shawn Webb wrote: > On Mon, Feb 25, 2019 at 06:18:42PM -0800, Rodney W. Grimes wrote: > > > > The modest increase in activation energy for that task seems worth it > > > > for the short-term gains of reduced integration cost (this code will > > > > greatly improve our ZFS-on-Linux test coverage.) > > > > > > > > Rod rightly points out that we haven't accepted SPDX tags alone as > > > > license statements. The standard GPL v2.0 boiler plate should be > added > > > > to this file along side the tag. > > > > > > I've copied the full copyright attribution that is in the > > > corresponding files on Linux. Is there some reason why FreeBSD > > > requires the files to be inflated with the full license text where the > > > original lacks it? > > > > I think for a few reasons, I doubt you copied the whole distribution > > that this file came from, as I am sure that distribution included > > a LICENSE file. Second if you actually read the GPL v2 documentation > > and follow what it says it says you must do this, just because some > > one else does not follow the rules of what the GPL v2 says does not > > give us to knowingling not do it. Third this is a particular dangerious > > area for BSD to be mixing a GPL code with its kernel, to my knowlege > > we have never had any gpl code in the kernel, no have we ever > > allowed it, but thats a seperate argument, that should be made. > > Would the arm64 DTS/DTB files count as "GPL code in the kernel?" > No. dts gets compiled into dtb. dtb is a separate work loaded by the boot loader. While one can compile it into the kernel, we don't ship like that. There's also a question as to whether or not these files are text representation of the hardware, and there being only one way to represent it (making it not copyrightable under at least US case law since it's a database). That question hasn't been litigated. Many hardware companies also dual license the dts. Since we're not incorporating it into the kernel, but merely using it as a standardized table (there's a separate group that controls the dts/dtb spec), I think we're safe from that angle as well. There's benefit from having it in-tree because the version of the spec evolves over time, and having the right version makes it harder to push this off into a port. Also, having them in-tree makes the project's compliance with GPL a no-op because it's all there in the open in a tagged VCS. tl;dr: I don't think this is an issue. > I, too, would like less GPL in project, both in userland in kernel. > But, I can understand the desire for gcov. Note that I'm not > advocating either way that FreeBSD perform an action. ;) > Given this is for TEST kernels, there's no issue here. While we'd like to be GPL free, let's not cut off our nose to spite our face. Given the interactions between different bits, the FreeBSD selling point of "well integrated" I think trumps the purity arguments because it's not code anybody would ever ship (and if they did, they'd get the proper warnings). Warner