Date: Tue, 16 Oct 2012 10:33:52 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Rick Macklem <rmacklem@uoguelph.ca> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-9@freebsd.org Subject: Re: svn commit: r241601 - in stable/9: lib/libc/rpc sys/rpc Message-ID: <507D7E60.90204@FreeBSD.org> In-Reply-To: <765985284.2313601.1350394614176.JavaMail.root@erie.cs.uoguelph.ca> References: <765985284.2313601.1350394614176.JavaMail.root@erie.cs.uoguelph.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
Thank you for the note Rick; On 10/16/2012 08:36, Rick Macklem wrote: > Pedro F. Giffuni wrote: >> Author: pfg >> Date: Tue Oct 16 01:37:17 2012 >> New Revision: 241601 >> URL: http://svn.freebsd.org/changeset/base/241601 >> >> Log: >> MFC r241143: >> >> rpc: be sure to free cl_netid and cl_tp. >> >> When creating a client with clnt_tli_create, it uses strdup to copy >> strings for these fields if nconf is passed in. clnt_dg_destroy frees >> these strings already. Make sure clnt_vc_destroy frees them in the >> same >> way. >> > I think the patch is fine. However, just fyi, there is no clnt_tli_create() > in the kernel and nothing in the kernel currently sets cl_netid or cl_tp non-NULL, as > far as I can see. The sys/ part is indeed there only to keep consistency with the libc version from which it was derived. According to OpenGrok though: clnt_tli_create() is declared extern in sys/rpc/clnt.h and used in lines 328 and 423 in sys/rpc/rpc_clnt.c. This can all be dead code but JIC it seems good to keep the check. Cheers, Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?507D7E60.90204>