From owner-freebsd-current@freebsd.org Mon Nov 30 21:44:56 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 11C6AA3D7AC for ; Mon, 30 Nov 2015 21:44:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qg0-x22b.google.com (mail-qg0-x22b.google.com [IPv6:2607:f8b0:400d:c04::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B87F312F2 for ; Mon, 30 Nov 2015 21:44:55 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by qgec40 with SMTP id c40so129756980qge.2 for ; Mon, 30 Nov 2015 13:44:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=L7rbcws1bih1ZSote5qFJfJLjXuGLVUYaWwrWD5b3yY=; b=wa8IV2Ts+B1ISvhj28Gvw5eA15oJ3Pv5RYo4r12kLAY+OD82Aou1ISRMZ3uY+fhMIS KsTaNlShdMBozhe/DxCQXQZiDwOgC/22HXkyCNh0FrA4SfyQprbVWMWloPB1PgfgdSFG XK/dfzT9E6ormXNEVTyHU+rk8/GuqSRvWRseQ5quqi9m8rOb6WhpL5kuZe4YefGxVGX1 QmBbgUFxWRMEtJCUuI7vTs8rmqcjaKQvrRSDAW8mNuSK854DnwR/UK/h6jACi8SdrpfG nOKL3Zra6goOLtZazZxzFoTIuGUJWdGxAD9gItyhWH6fSmPrk+DLsu7Tte7wchB6om1z k5cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=L7rbcws1bih1ZSote5qFJfJLjXuGLVUYaWwrWD5b3yY=; b=Wk97ZlYolzPUQF4jExsD29K9W3rXzqK3aW3UFxXNxvP3XmTNIuxml4hEyh78Qeu2EG lNUwRdQPslnH+vFRuYpS9x2MkyS4dAE8E0hZJ7+gqNl+KguGMA2NUI8bqqL+u3aSUWiZ fs2TOs1AJHopGzBPcYUxMgMOOdlhHjnC9LoPogmAOSJs0sdgYhbce2QlL4EGUriN/Yvs kiQS9N4xzwKeUI11Q1uA9OH5OL1L/BR98AjBaVBBPfxnee+AZ1nJ+Qf6zxG7KAnL/UXy I+EBDX1e2tcB2WnfEclUTTSgBJtrpyv86TO9ZOsBgcGCUUnKmhsgPvB6hW0KgifjEvtk 3GWw== X-Gm-Message-State: ALoCoQlg7V1eaNgips7iymt955JAmrZA12vKNXiOlmADT7gPALUvPNtj0xJ1O1nQbLNFD3QwWGJk MIME-Version: 1.0 X-Received: by 10.140.40.38 with SMTP id w35mr76335448qgw.52.1448919894661; Mon, 30 Nov 2015 13:44:54 -0800 (PST) Sender: wlosh@bsdimp.com Received: by 10.140.27.181 with HTTP; Mon, 30 Nov 2015 13:44:54 -0800 (PST) X-Originating-IP: [69.53.245.31] In-Reply-To: <565CB176.4070906@freebsd.org> References: <564E0322.8050308@freebsd.org> <3514235.7QMnNNElsE@ralph.baldwin.cx> <565CB176.4070906@freebsd.org> Date: Mon, 30 Nov 2015 14:44:54 -0700 X-Google-Sender-Auth: kLhyZqNGREeAE7QS2q0aETaJ7qM Message-ID: Subject: Re: sys/modules "make clean" seems broken again From: Warner Losh To: Sean Bruno Cc: John Baldwin , FreeBSD Current Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2015 21:44:56 -0000 On Mon, Nov 30, 2015 at 1:28 PM, Sean Bruno wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > > > On 11/19/15 15:42, Warner Losh wrote: > > > > > > On Thu, Nov 19, 2015 at 11:12 AM, John Baldwin > > wrote: > > > > On Thursday, November 19, 2015 09:13:06 AM Sean Bruno wrote: > >> I thought I fixed this a year or two ago, but now a "make clean" > >> in sys/modules seems to leave bus_if.h device_if.h and pci_if.h > >> in the directory. > >> > >> Should I just add these to the clean targets? > > > > Blame Warner as his MFILES changes broke this. In particular, see > > r287263 which turned off cleaning these up. I'm not sure what that > > broke that caused it to be disabled. > > > > Your change is a gross hack though. > > > > > > Yes. The reason I had to break it was that there were a few files > > named _if.c and _if.h in the tree that would get deleted when make > > clean was run in the modules. > > > > I'll take another run at fixing this. Sean's "fix" is a horrible > > hack. > > > > Warner > > > Just bouncing a ping here. I haven't actually checked to see if the > last weeks' commits to head fixed this, but I suspect this hasn't been > addressed. What do we want to do different if not this hackery I propose? > Your hackery wouldn't actually fix it completely, just mostly for a common case. Warner