From owner-freebsd-arch Wed Jan 15 5:42:40 2003 Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E667F37B405 for ; Wed, 15 Jan 2003 05:42:36 -0800 (PST) Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6D5B843F43 for ; Wed, 15 Jan 2003 05:42:31 -0800 (PST) (envelope-from des@ofug.org) Received: by flood.ping.uio.no (Postfix, from userid 2602) id DF4715378; Wed, 15 Jan 2003 14:42:29 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Bruce Evans Cc: arch@FreeBSD.ORG Subject: Re: Buglet in disklabel References: <20030116003206.C23422-100000@gamplex.bde.org> From: Dag-Erling Smorgrav Date: Wed, 15 Jan 2003 14:42:29 +0100 In-Reply-To: <20030116003206.C23422-100000@gamplex.bde.org> (Bruce Evans's message of "Thu, 16 Jan 2003 00:35:00 +1100 (EST)") Message-ID: Lines: 19 User-Agent: Gnus/5.090007 (Oort Gnus v0.07) Emacs/21.2 (i386--freebsd) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Bruce Evans writes: > Looks good. You could also remove the bzero() before one of the calls > to getasciilabel() (the one that passes a local variable that would > more obviously be unitialized if it weren't bzero()ed). Like this? @@ -858,7 +858,6 @@ warnx("can't reopen %s for reading", tmpfil); break; } - bzero((char *)&label, sizeof(label)); if (getasciilabel(fp, &label)) { *lp = label; if (writelabel(f, bootarea, lp) == 0) { DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message