From owner-freebsd-arch@FreeBSD.ORG Wed Oct 27 20:56:38 2010 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 12C6C1065679; Wed, 27 Oct 2010 20:56:38 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id D4AB28FC15; Wed, 27 Oct 2010 20:56:37 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 657F446B09; Wed, 27 Oct 2010 16:56:37 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 7094E8A009; Wed, 27 Oct 2010 16:56:36 -0400 (EDT) From: John Baldwin To: Attilio Rao Date: Wed, 27 Oct 2010 16:49:47 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; ) References: <201010271355.40685.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201010271649.47880.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Wed, 27 Oct 2010 16:56:36 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: freebsd-arch@freebsd.org Subject: Re: [PATCH] Headers for the x86 subtree X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Oct 2010 20:56:38 -0000 On Wednesday, October 27, 2010 4:00:15 pm Attilio Rao wrote: > 2010/10/27 John Baldwin : > > On Wednesday, October 27, 2010 10:56:06 am Attilio Rao wrote: > >> This patch should convert a (simple and 100% shared between amd64 and > >> i386 header) under the x86 sub-tree. Please note that in this patch I > >> "svn cp" the file from sys/amd64/include/mptable.h into > >> sys/x86/include/mptable.h: > >> http://www.freebsd.org/~attilio/headers-x86.diff > >> > >> This is someway a POC, that I really want to get in. The idea is > >> simple and someway follows the pc98 case (even if not entirely): the > >> files under machine/include/* became just mere stubs for x86/include/* > >> contents and redirect there. > >> This won't particulary help reducing the number of available files, > >> but generally removing verbatim and would also be the way to go for > >> handling MFCs. > >> If you find this is the right way I'll commit the fix and start moving > >> other files as time permits. > > > > No, we want to do this differently because we also want this to work in > > userland. (e.g. I'd like to outright move mca.h to x86/include and then use > > '#include ' in both kernel and userland for it). We'd need some > > special glue to setup an 'x86' symlink during a kernel build that points to > > @/x86/include as we do now to setup an 'i386' link for pc98 kernels. > > > > We'd also need to install the x86 headers into /usr/include during an > > installworld. Warner has some more pointers on this I think. > > So you probabilly are suggesting to go w/ the "pc98 approach". > I'm fine with it, I'll try to look for how it works and implement as well. Thanks. I think it is fine to use '#include ' in code directly with this approach as well. I only think we should provide wrappers in /usr/include/machine if compatibility is needed. mca.h and mptable.h shouldn't need compatibility for example, but specialreg.h might. -- John Baldwin