From owner-svn-src-head@freebsd.org Wed Aug 31 19:18:38 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 86F6FBCA440; Wed, 31 Aug 2016 19:18:38 +0000 (UTC) (envelope-from gonzo@id.bluezbox.com) Received: from id.bluezbox.com (id.bluezbox.com [45.55.20.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 68C34616; Wed, 31 Aug 2016 19:18:38 +0000 (UTC) (envelope-from gonzo@id.bluezbox.com) Received: from [208.184.220.60] (helo=limiting-factor.dolby.net) by id.bluezbox.com with esmtpsa (TLSv1:ECDHE-RSA-AES256-SHA:256) (Exim 4.86_2 (FreeBSD)) (envelope-from ) id 1bfAek-000F0r-FI; Wed, 31 Aug 2016 11:54:38 -0700 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r305114 - head/sys/arm/ti From: Oleksandr Tymoshenko In-Reply-To: <201608310722.u7V7MEvA094475@repo.freebsd.org> Date: Wed, 31 Aug 2016 11:54:08 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201608310722.u7V7MEvA094475@repo.freebsd.org> To: Luiz Otavio O Souza X-Mailer: Apple Mail (2.3124) Sender: gonzo@id.bluezbox.com X-Spam-Level: -- X-Spam-Report: Spam detection software, running on the system "id.bluezbox.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see The administrator of that system for details. Content preview: > On Aug 31, 2016, at 12:22 AM, Luiz Otavio O Souza wrote: > > Author: loos > Date: Wed Aug 31 07:22:14 2016 > New Revision: 305114 > URL: https://svnweb.freebsd.org/changeset/base/305114 > > Log: > Allow the use of control module extensions to cope with specific platform > features. > > Sponsored by: Rubicon Communications, LLC (Netgate) > > Modified: > head/sys/arm/ti/ti_scm.c > > Modified: head/sys/arm/ti/ti_scm.c > ============================================================================== > --- head/sys/arm/ti/ti_scm.c Wed Aug 31 07:03:06 2016 (r305113) > +++ head/sys/arm/ti/ti_scm.c Wed Aug 31 07:22:14 2016 (r305114) > @@ -131, 7 +131, 11 @@ ti_scm_attach(device_t dev) > > ti_scm_sc = sc; > > - return (0); > + /* Attach platform extensions, if any. */ > + bus_generic_probe(dev); > + bus_enumerate_hinted_children(dev); > + > + return (bus_generic_attach(dev)); > } [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Aug 2016 19:18:38 -0000 > On Aug 31, 2016, at 12:22 AM, Luiz Otavio O Souza = wrote: >=20 > Author: loos > Date: Wed Aug 31 07:22:14 2016 > New Revision: 305114 > URL: https://svnweb.freebsd.org/changeset/base/305114 >=20 > Log: > Allow the use of control module extensions to cope with specific = platform > features. >=20 > Sponsored by: Rubicon Communications, LLC (Netgate) >=20 > Modified: > head/sys/arm/ti/ti_scm.c >=20 > Modified: head/sys/arm/ti/ti_scm.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/arm/ti/ti_scm.c Wed Aug 31 07:03:06 2016 = (r305113) > +++ head/sys/arm/ti/ti_scm.c Wed Aug 31 07:22:14 2016 = (r305114) > @@ -131,7 +131,11 @@ ti_scm_attach(device_t dev) >=20 > ti_scm_sc =3D sc; >=20 > - return (0); > + /* Attach platform extensions, if any. */ > + bus_generic_probe(dev); > + bus_enumerate_hinted_children(dev); > + > + return (bus_generic_attach(dev)); > } Is bus_enumerate_hinted_children really required? I think all TI = platforms are FDT-compatible=20=