From owner-freebsd-current Thu Sep 17 13:17:51 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA17414 for freebsd-current-outgoing; Thu, 17 Sep 1998 13:17:51 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from panzer.plutotech.com (panzer.plutotech.com [206.168.67.125]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA17342 for ; Thu, 17 Sep 1998 13:17:29 -0700 (PDT) (envelope-from ken@panzer.plutotech.com) Received: (from ken@localhost) by panzer.plutotech.com (8.9.1/8.8.5) id OAA05007; Thu, 17 Sep 1998 14:17:00 -0600 (MDT) From: "Kenneth D. Merry" Message-Id: <199809172017.OAA05007@panzer.plutotech.com> Subject: Re: LINT not up to date In-Reply-To: <19980917130437.A4237@nuxi.com> from David O'Brien at "Sep 17, 98 01:04:37 pm" To: obrien@NUXI.com Date: Thu, 17 Sep 1998 14:17:00 -0600 (MDT) Cc: freebsd-current@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL28s (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG David O'Brien wrote... > > They're both in LINT. Look again. > > > > # grep "Id" LINT > > # $Id: LINT,v 1.467 1998/09/17 03:15:30 msmith Exp $ > > # egrep 'SCSI_CAM|SCSI_DELAY' LINT > > options SCSI_DELAY=8000 # Be pessimistic about Joe SCSI device > > It needs to be documented, both in LINT and in the 3.0 release notes that > this is *NOT* in seconds any more. Also document here, what it is > measured in. Yeah, we should probably put something in LINT. > I've currently got SCSI_DELAY=20 in my pre-CAM kernel. Wouldn't like to > see what would happen if I don't change it. What will happen is that your kernel compile will fail, because SCSI_DELAY is less than 100. :) I thought of situations like that, and I put a check in cam_xpt.c to make sure folks don't set the delay lower than 100ms: /* * This is the number of seconds we wait for devices to settle after a SCSI * bus reset. */ #ifndef SCSI_DELAY #define SCSI_DELAY 2000 #endif #if (SCSI_DELAY < 100) #error "SCSI_DELAY is in milliseconds, not seconds! Please use a larger value" #endif Ken -- Kenneth Merry ken@plutotech.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message