From owner-svn-ports-all@FreeBSD.ORG Mon Aug 11 08:04:28 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 34927B5D; Mon, 11 Aug 2014 08:04:28 +0000 (UTC) Received: from mail-pa0-x230.google.com (mail-pa0-x230.google.com [IPv6:2607:f8b0:400e:c03::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DC3F22E5F; Mon, 11 Aug 2014 08:04:27 +0000 (UTC) Received: by mail-pa0-f48.google.com with SMTP id et14so10663584pad.21 for ; Mon, 11 Aug 2014 01:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:reply-to:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=eSSQlrQ2Mc2Iu3v9gytpOQGxFAmPqpttKFBw1k/76L8=; b=PI0QI0BmKzO6s07Yr8GEl4ueowDALuGjXmnUGEOm9u7oZv+WKa2yO1DPe8QBHJlSYO tjFdEOj8X4SjtPklcpLbgiwZEL+FmjtnwghbEafy2Vf0CKTiBhv8+WW60urxSbCVG9Na I0HDuQ07+pM96IGzed4EOJsEqaM3sB17ZBdyeTqx0jVjEIVkTJ6ywwxFIKw1cG/b1wX+ Ge484AeC9KBIQmCpdG6zfYC+4C/bfo7G8TLMEi2tEjL9KQQSso3/JxnjcknmI8jxWBX7 O7GiZqNoVXEvR7K6l5HODRQUiM1C8scyhYROfsR/uBxPMkMU4TvOAjHNL1RvdtpOQMnv CQvg== X-Received: by 10.66.100.200 with SMTP id fa8mr40498277pab.23.1407744267537; Mon, 11 Aug 2014 01:04:27 -0700 (PDT) Received: from ?IPv6:2001:44b8:31ae:7b00:898d:2993:e1fd:8220? (2001-44b8-31ae-7b00-898d-2993-e1fd-8220.static.ipv6.internode.on.net. [2001:44b8:31ae:7b00:898d:2993:e1fd:8220]) by mx.google.com with ESMTPSA id w7sm10524762pbs.74.2014.08.11.01.04.25 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Aug 2014 01:04:27 -0700 (PDT) Sender: Kubilay Kocak Message-ID: <53E87906.7050402@FreeBSD.org> Date: Mon, 11 Aug 2014 18:04:22 +1000 From: Kubilay Kocak Reply-To: koobs@FreeBSD.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Max Brazhnikov , Alexey Dokuchaev Subject: Re: svn commit: r364518 - in head: accessibility/py-papi audio/py-al devel/py-astroid devel/py-dynrules devel/py-game devel/py-logilab-common devel/py-ocempgui devel/py-ply devel/py-sdl2 devel/pychecke... References: <53e7336d.2c4d.2257f090@svn.freebsd.org> <2556564.WKGpsAPjlp@mercury.ph.man.ac.uk> <20140810164416.GA43983@FreeBSD.org> <1541578.rWvlqK3ZQn@mercury.ph.man.ac.uk> In-Reply-To: <1541578.rWvlqK3ZQn@mercury.ph.man.ac.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Marcus von Appen , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Aug 2014 08:04:28 -0000 On 11/08/2014 5:50 PM, Max Brazhnikov wrote: > On Sun, 10 Aug 2014 16:44:16 +0000 Alexey Dokuchaev wrote: >> On Sun, Aug 10, 2014 at 03:40:11PM +0000, Max Brazhnikov wrote: >>> On Sun, 10 Aug 2014 09:55:16 +0000 Alexey Dokuchaev wrote: >>>> On Sun, Aug 10, 2014 at 08:55:08AM +0000, Marcus von Appen wrote: >>>>> New Revision: 364518 >>>>> URL: http://svnweb.freebsd.org/changeset/ports/364518 >>>>> QAT: https://qat.redports.org/buildarchive/r364518/ >>>>> >>>>> -USES= pkgconfig >>>>> +USES= pkgconfig python:2 >>>>> USE_GNOME= atk >>>>> -USE_PYTHON= 2 >>>>> -USE_PYDISTUTILS=yes >>>>> -PYDISTUTILS_AUTOPLIST= yes >>>>> +PYTHON_FEATURES=autoplist distutils >>>> >>>> Yuck, this PYTHON_FEATURES knob is ugly. Why not follow Perl's example >>>> instead (USES=perl and USE_PERL)? It both makes more sense and shorter. >>> >>> ugly or not, it's a matter of taste. [...] >> >> Not really. It is also 1) inconsistent with USE_PERL, and 2) is overly >> long knob name (breaks indentation). > > 1) > I don't think USE_PERL is worthy of comparison, USE_XXX > shouldn't be used after conversion to USES: > - it complicates the transition > - it's inconsistent with other old style USE_YXZ > > I'd like to see something like XXX_COMPONENTS for this, > but it is too long :) Sounds like we want something that describes foo's *ports framework* bits rather than foo's bits, which neither FOO_FEATURES nor FOO_COMPONENTS seems to indicate. USE_FOO is less ambiguous, but not perfect, and feels better given it is a verb, connecting its use semantically to the value(s) specified. Without having to inventing a new one without a good warrant to do so, USE_FOO is clean and has an existing implementer. Downside of course is that it's in use, though that's insufficient justification not to use it however. > 2) I'd prefer broken indentation to clear meaning. I like clean indentation too. USE_PYDISTUTILS makes for lots of cognitive dissonance at the moment ;) If we can do functional, obvious *and* beautiful, we ought to put in the few extra cycles to do so. koobs