From owner-svn-ports-all@freebsd.org  Mon Dec 19 16:53:44 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B2532C88215;
 Mon, 19 Dec 2016 16:53:44 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from anoxia.adamw.org (anoxia.adamw.org [104.225.8.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "anoxia.adamw.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 153EC1ADE;
 Mon, 19 Dec 2016 16:53:44 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by anoxia.adamw.org (OpenSMTPD) with ESMTPSA id 03f33cce
 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO;
 Mon, 19 Dec 2016 09:53:42 -0700 (MST)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\))
Subject: Re: svn commit: r428858 - head/ftp/curl
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <201612181520.uBIFKplk029455@repo.freebsd.org>
Date: Mon, 19 Dec 2016 09:53:39 -0700
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <05E4B71C-438F-41F5-B1C9-4E7DA0F314BB@adamw.org>
References: <201612181520.uBIFKplk029455@repo.freebsd.org>
To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>
X-Mailer: Apple Mail (2.3259)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Dec 2016 16:53:44 -0000

> On 18 Dec, 2016, at 8:20, Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> =
wrote:
>=20
> Author: sunpoet
> Date: Sun Dec 18 15:20:50 2016
> New Revision: 428858
> URL: https://svnweb.freebsd.org/changeset/ports/428858
>=20
> Log:
>  - Change HTTP2 dependency from www/nghttp2 to www/libnghttp2
>  - Enable HTTP2 option by default
>  - Bump PORTREVISION for dependency and package change
>=20
> Modified:
>  head/ftp/curl/Makefile
>=20
> Modified: head/ftp/curl/Makefile
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/ftp/curl/Makefile	Sun Dec 18 15:20:42 2016	=
(r428857)
> +++ head/ftp/curl/Makefile	Sun Dec 18 15:20:50 2016	=
(r428858)
> @@ -3,7 +3,7 @@
>=20
> -HTTP2_BUILD_DEPENDS=3D	nghttp2>=3D1.0.0:www/nghttp2
> -HTTP2_CONFIGURE_WITH=3D	nghttp2
> -HTTP2_LIB_DEPENDS=3D	libnghttp2.so:www/nghttp2
> -HTTP2_RUN_DEPENDS=3D	nghttp2>=3D1.0.0:www/nghttp2
> +HTTP2_BUILD_DEPENDS=3D	libnghttp2>=3D1.0.0:www/libnghttp2
> +HTTP2_CONFIGURE_WITH=3D	libnghttp2
> +HTTP2_LIB_DEPENDS=3D	libnghttp2.so:www/libnghttp2
> +HTTP2_RUN_DEPENDS=3D	libnghttp2>=3D1.0.0:www/libnghttp2

Hi Sunpoet,

Having BUILD, RUN, and LIB depends on the same port looks odd; shouldn't =
just LIB_DEPENDS be sufficient? www/mod_http2-devel does it too.

# Adam


--=20
Adam Weinberger
adamw@adamw.org
https://www.adamw.org