From owner-freebsd-security Mon Apr 16 12:45:19 2001 Delivered-To: freebsd-security@freebsd.org Received: from mx.databus.com (p101-44.acedsl.com [160.79.101.44]) by hub.freebsd.org (Postfix) with ESMTP id D10C837B43C; Mon, 16 Apr 2001 12:45:08 -0700 (PDT) (envelope-from barney@mx.databus.com) Received: (from barney@localhost) by mx.databus.com (8.11.3/8.11.3) id f3GJgoH49895; Mon, 16 Apr 2001 15:42:50 -0400 (EDT) (envelope-from barney) Date: Mon, 16 Apr 2001 15:42:49 -0400 From: Barney Wolff To: "E.B. Dreger" Cc: Kris Kennaway , Wes Peters , freebsd-security@FreeBSD.ORG, net@FreeBSD.ORG, provos@OpenBSD.org Subject: Re: non-random IP IDs Message-ID: <20010416154249.A49858@mx.databus.com> References: <20010416121019.D10023@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0.1i In-Reply-To: ; from eddy+public+spam@noc.everquick.net on Mon, Apr 16, 2001 at 07:24:07PM +0000 Sender: owner-freebsd-security@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org If ip_randomid() is an asm rather than C code, I have sometimes seen problems with an asm func calling another asm func. That was long ago and far away, but is the only reason I can think of for that change. But whether the id is random or a counter, there is no reason to htons it, as long as it's treated consistently, with externals never compared with internals. Barney Wolff > > Date: Mon, 16 Apr 2001 12:10:19 -0700 > > From: Kris Kennaway > > > > I can't think of anything off the top of my head, but there was some > > reason why OpenBSD made this change: > > > > - ip_copy->ip_id = htons(ip_randomid()); > > + ip_copy->ip_id = ip_randomid(); > > + HTONS(ip_copy->ip_id); > > > > Presumably there was some reasoning there. Niels, can you shed any > > light? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-security" in the body of the message