From owner-svn-src-head@FreeBSD.ORG Fri Jan 14 13:20:12 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 83177106564A; Fri, 14 Jan 2011 13:20:12 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 533B18FC13; Fri, 14 Jan 2011 13:20:12 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id E05D346B52; Fri, 14 Jan 2011 08:20:11 -0500 (EST) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id ADABB8A009; Fri, 14 Jan 2011 08:20:10 -0500 (EST) From: John Baldwin To: Warner Losh Date: Fri, 14 Jan 2011 08:17:32 -0500 User-Agent: KMail/1.13.5 (FreeBSD/7.4-CBSD-20110107; KDE/4.4.5; amd64; ; ) References: <201101122108.p0CL8o3Q012038@svn.freebsd.org> <20110113104728.L1003@besplex.bde.org> <4D2F78DF.1090106@bsdimp.com> In-Reply-To: <4D2F78DF.1090106@bsdimp.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201101140817.32393.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Fri, 14 Jan 2011 08:20:10 -0500 (EST) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, Matthew D Fleming , svn-src-all@freebsd.org, src-committers@freebsd.org, Bruce Evans Subject: Re: svn commit: r217330 - head/sys/x86/x86 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2011 13:20:12 -0000 On Thursday, January 13, 2011 5:12:47 pm Warner Losh wrote: > On 01/12/2011 17:06, Bruce Evans wrote: > > On Wed, 12 Jan 2011, John Baldwin wrote: > > > >>> Log: > >>> Fix a brain fart. Since this file is shared between i386 and > >>> amd64, a > >>> bus_size_t may be 32 or 64 bits. Change the bounce_zone alignment > >>> field > >>> to explicitly be 32 bits, as I can't really imagine a DMA device that > >>> needs anything close to 2GB alignment of data. > >> > >> Hmm, we do have devices with 4GB boundaries though. I think I'd > >> prefer it if > >> you instead if you did this: > >> > >> #if defined(amd64) || defined(PAE) > >> #define SYSCTL_ADD_BUS_SIZE_T SYSCTL_ADD_UQUAD > >> #else > >> #define SYSCTL_ADD_BUS_SIZE_T SYSCTL_ADD_UINT > >> #endif > >> > >> and then just used SYSCTL_ADD_BUS_SIZE_T() in the code so we could > >> let the > >> members in the bounce zone retain the same types passed to > >> bus_dma_tag_create(). > > > > U_LONG should work on all arches. malloc(9) still uses u_long instead > > of size_t. This works for scalars even on the recently removed i386's > > with 32-bit longs where u_long is larger than size_t, since larger is > > a fail-safe direction. This fails for pointers. Newer parts of malloc() > > and uma are broken unless u_long is the same as uintptr_t, since they > > cast pointers to u_long. This direction is fail-safe too, but gcc warns > > about it. > > u_long doesn't work for N32. There, the pointers may only be 32-bit, > but PAs ar 64-bit. Longs are only 32-bits. It doesn't work on PAE either. bus_size_t is not the same as size_t in this case. -- John Baldwin