From owner-freebsd-x11@FreeBSD.ORG Tue Dec 7 09:21:11 2004 Return-Path: Delivered-To: freebsd-x11@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8199716A4CE for ; Tue, 7 Dec 2004 09:21:11 +0000 (GMT) Received: from niobe.ijs.si (mail.ijs.si [193.2.4.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2EF6743D2F for ; Tue, 7 Dec 2004 09:21:11 +0000 (GMT) (envelope-from dejan.lesjak@ijs.si) Received: from localhost (localhost.ijs.si [127.0.0.1]) by niobe.ijs.si (Postfix) with ESMTP id 5883A208F88; Tue, 7 Dec 2004 10:21:10 +0100 (CET) Received: from niobe.ijs.si ([127.0.0.1]) by localhost (niobe.ijs.si [127.0.0.1]) (amavisd-new, port 10028) with ESMTP id 61312-14; Tue, 7 Dec 2004 10:21:08 +0100 (CET) Received: from rincewind.ijs.si (rincewind.ijs.si [193.2.4.137]) by niobe.ijs.si (Postfix) with ESMTP id 264B0208F76; Tue, 7 Dec 2004 10:21:07 +0100 (CET) Received: from [193.2.4.12] (azazel.ijs.si [193.2.4.12]) by rincewind.ijs.si (Postfix) with ESMTP id C9F0E80303E; Tue, 7 Dec 2004 10:21:07 +0100 (CET) Message-ID: <41B57602.9050106@ijs.si> Date: Tue, 07 Dec 2004 10:21:06 +0100 From: Dejan Lesjak User-Agent: Mozilla Thunderbird 0.8 (Windows/20040914) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Michael Nottebrock References: <20041205072925.GG72828@xor.obsecurity.org> <200412051226.18976.michaelnottebrock@gmx.net> <200412061803.39398.dejan.lesjak@ijs.si> <200412070625.03222.michaelnottebrock@gmx.net> In-Reply-To: <200412070625.03222.michaelnottebrock@gmx.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: amavisd-new at ijs.si cc: freebsd-x11@freebsd.org cc: Kris Kennaway Subject: Re: [ports-i386@dosirak.kr.freebsd.org: kaptain-0.72 failed on i386 5] X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Dec 2004 09:21:11 -0000 Michael Nottebrock wrote: > On Monday, 6. December 2004 18:03, Dejan Lesjak wrote: > >>On Sunday 05 of December 2004 12:26, Michael Nottebrock wrote: >> >>>On Sunday, 5. December 2004 08:29, Kris Kennaway wrote: >>> >>>>checking for libXext... no >>>>configure: error: We need a working libXext to proceed. Since configure >>>>can't find it itself, we stop here assuming that make wouldn't find >>>>them either. >>> >>>I took the liberty of fixing this one too, it borrows a configure check >>>from KDE but only depends on QT. >> >>Thanks again for taking care of USE_KDELIBS_VER cases and for this one. >>There are a couple more of this type, like games/qgo, cad/qfsm... This is >>perhaps a naive question but would it be possible to put >>CONFIGURE_ARGS+=--x-libraries=${X11BASE}/lib >>--x-includes=${X11BASE}/include under USE_QT_VER section of bsd.kde.mk >>instead of under USE_KDELIBS_VER? > > > Not good, USE_QT_VER ports aren't guaranteed to use that configure check (or > even to use a configure script that understands or manages to gracefully > ignore these parameters). Aha, thanks for the explanation. >>Or to even take it further and put it >>under .if defined(GNU_CONFIGURE) section in bsd.port.mk, perhaps depending >>on whether WITHOUT_X11 is defined? > > > That might work, but bsd.port.mk is portmgr territory, I can't touch it. Yes, yes, it was just a question. Though if it would cause trouble under USE_QT, then it would cause more trouble in bsd.port.mk. But the PR 74536 should be the right hting anyway, so just forget my rambling on this one :) >>It seems that would avoid the need to >>specify it in couple of ports separately. > > > There aren't that many US_QT_VER consumers in the tree which need those extra > CONFIGURE_ARGS - if you want, I could save you some donkey work, pick them > out of kris' error reports and commit the fixes myself. Nah, it's no problem, I already have the patches to be commited/send to maintainers (adding CONFIGURE_ARGS like in kaptain). I just wanted to ask first whether you would prefer to do that in bsd.kde.mk. Just from a quick look at logs from kdebase and gtk-qt-engine, it seems that those will need xmkmf and therefore imake build dep. I haven't come to those yet to take a closer look though. Dejan