From owner-freebsd-questions  Wed Mar 29 14:25:53 2000
Delivered-To: freebsd-questions@freebsd.org
Received: from mail.hellasnet.gr (mail.hellasnet.gr [212.54.192.3])
	by hub.freebsd.org (Postfix) with ESMTP id 1CD5837B575
	for <questions@freebsd.org>; Wed, 29 Mar 2000 14:25:20 -0800 (PST)
	(envelope-from keramida@ceid.upatras.gr)
Received: from hades.hell.gr (ppp4.patr.hellasnet.gr [212.54.197.19])
	by mail.hellasnet.gr (8.9.1/8.9.1) with ESMTP id AAA10758
	for <questions@freebsd.org>; Thu, 30 Mar 2000 00:24:18 +0200 (GMT)
Received: (from charon@localhost)
	by hades.hell.gr (8.9.3/8.9.3) id SAA12522
	for questions@freebsd.org; Wed, 29 Mar 2000 18:28:47 +0300 (EEST)
	(envelope-from charon)
Date: Wed, 29 Mar 2000 18:28:46 +0300
From: Giorgos Keramidas <keramida@ceid.upatras.gr>
To: questions@freebsd.org
Subject: CVS logs question
Message-ID: <20000329182846.A12501@hades.hell.gr>
Reply-To: keramida@ceid.upatras.gr
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 1.0i
X-PGP-Fingerprint: 62 45 D1 C9 26 F9 95 06  D6 21 2A C8 8C 16 C0 8E
Sender: owner-freebsd-questions@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

I was browsing through the CVS logs this afternoon, and found the
following in cp/utils.c,v:

  revision 1.21
  date: 1998/11/18 11:47:45;  author: bde;  state: Exp;  lines: +2 -2
  branches:  1.21.2;
  Don't use mmap() for non-regular files, since st_size is only meaningful
  for regular files.  This fixes recent breakage of cp'ing from /dev/zero.
  /dev/zero doesn't support mmap(), but the device driver mmap routines are
  not called for mapping 0 bytes, so the error was not detected.  mmap()
  can't even be used for cp'ing special files that support mmap(), since
  there is general way to determine the file size.

The last sentence is obviously missing a negation; I would guess it was
meant to be '..since there is no general way to determine the file size.'
                              ^^

However, I was wandering are we to correct such things in the logs, or
this seems like a useless thing to do?

- Giorgos Keramidas


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-questions" in the body of the message