From owner-svn-src-head@freebsd.org Wed Feb 5 21:35:03 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7522422FCA2; Wed, 5 Feb 2020 21:35:03 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-vk1-xa43.google.com (mail-vk1-xa43.google.com [IPv6:2607:f8b0:4864:20::a43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48CZbV32V2z4DMn; Wed, 5 Feb 2020 21:35:02 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-vk1-xa43.google.com with SMTP id g7so1004168vkl.12; Wed, 05 Feb 2020 13:35:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LNCtBoeq8Qwqi1YJuPEhTl3bQ6FlHoHuehI57EFzovM=; b=Do3Cmd76hRvDJuUCxqRe13bKSCCvtdzFVnjJxcuaRXtfYQgU6pRdOnBUL9KRkr96uv joIi5BmoE3Uomu39hP3M+8xKs4ebuKA8ULtOoo2tw96aMRgV3TCTYY7eptxRGqUpemRo +nF89IPZ6cbkW0nAqx/BQ+GDZ+bB2v/bHQIQlce5yaMnSEBKtO/FeC52b01PIxDtDRU/ iv+jM3463hh89LNwbtJUkknBziXsa6/9Gw23fhm98LNLD4lrOZ6Y59lrrMsyQFhFv+yH mkJkKZT7lII35K0Hj5bFNqmhRxY2kk6BLjXyopVcC02nlnoiUOlALrfFp1mSaW7P2k3X txPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LNCtBoeq8Qwqi1YJuPEhTl3bQ6FlHoHuehI57EFzovM=; b=ETErRE29icp5pPA41T202AHM1m1UTTA4ENNKmKPyxDg3liT12N8bRUgae2LqymYGPd mjcnL1K13q5fyBzlQ3Rj3f9URZlSnTGqcJExYYZn7lJltAChafEABWxmKJhRmc2jG6qx 564VXzan4lksjg/zrnSaqMQXmqDXzA5TYxXdQO7WPpMJNSe5NAYIZPwrIwpICGODn8vV o4R7yowqKjHld8V5CLhs5JDBHfJHUmQ7giIkMS7ZMJpzoccAyjAJG4sdgeJ4hHzTLJJQ 1erssjnOo74LIwsI3mSm+GG22TYiUUSP8zQoDPYIzUgkpS0Lsv59QGkOYaI1X/v3UyyZ fDjA== X-Gm-Message-State: APjAAAUqhuez2T8c6p3plzdqxfhMXRU81MHmRkVNzGCe7ceszSIlncxB DNvn/DYnUQdegnJ+Z7DjLTUWe+Et5TrOmGUM5FDCGjpk X-Google-Smtp-Source: APXvYqzDi3ZScoeXVG5EaADOnDvsNF1KoG3li4hDSBB82CTIgBQoez+65xVEstpOYQSJ1DxroWqFZmr4XzsWKZz49aQ= X-Received: by 2002:a1f:9c92:: with SMTP id f140mr3053718vke.87.1580938500347; Wed, 05 Feb 2020 13:35:00 -0800 (PST) MIME-Version: 1.0 References: <202002012036.011KaajV051873@repo.freebsd.org> In-Reply-To: <202002012036.011KaajV051873@repo.freebsd.org> From: Enji Cooper Date: Wed, 5 Feb 2020 13:34:48 -0800 Message-ID: Subject: Re: svn commit: r357384 - head/sys/kern To: Mateusz Guzik Cc: src-committers , svn-src-all , svn-src-head , Martin Matuska Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 48CZbV32V2z4DMn X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Do3Cmd76; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::a43 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE_FREEMAIL(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; IP_SCORE(0.00)[ip: (2.52), ipnet: 2607:f8b0::/32(-1.98), asn: 15169(-1.74), country: US(-0.05)]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[3.4.a.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Feb 2020 21:35:03 -0000 On Sat, Feb 1, 2020 at 12:36 PM Mateusz Guzik wrote: > > Author: mjg > Date: Sat Feb 1 20:36:35 2020 > New Revision: 357384 > URL: https://svnweb.freebsd.org/changeset/base/357384 > > Log: > cache: remove vnode -> path lookup disablement > > It seems to be of little to no use even when debugging. > > Interested parties can resurrect it and gate compilation with a macro. Hi Mateusz, This orphans some other things in the kernel that should potentially be removed as well: $ grep -r 'debug\.disablefullpath' ~/svn/freebsd/src/sys/ sys/kern/kern_jail.c: /* proceed if sysctl debug.disablefullpath == 1 */ sys/kern/vfs_mount.c: /* debug.disablefullpath == 1 results in ENODEV */ Cheers, -Enji