From owner-cvs-all@FreeBSD.ORG Tue Jan 20 14:09:50 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D348B16A4CF for ; Tue, 20 Jan 2004 14:09:50 -0800 (PST) Received: from root.org (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id AD3A043D48 for ; Tue, 20 Jan 2004 14:09:47 -0800 (PST) (envelope-from nate@root.org) Received: (qmail 97965 invoked by uid 1000); 20 Jan 2004 22:09:48 -0000 Date: Tue, 20 Jan 2004 14:09:48 -0800 (PST) From: Nate Lawson To: Poul-Henning Kamp In-Reply-To: <9202.1074631158@critter.freebsd.dk> Message-ID: <20040120140012.N97860@root.org> References: <9202.1074631158@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2004 22:09:50 -0000 On Tue, 20 Jan 2004, Poul-Henning Kamp wrote: > In message <200401201445.24897.jhb@FreeBSD.org>, John Baldwin writes: > >On Tuesday 20 January 2004 01:23 pm, Poul-Henning Kamp wrote: > >> In message <200401201234.45472.jhb@FreeBSD.org>, John Baldwin writes: > >> >On Monday 19 January 2004 04:27 pm, Poul-Henning Kamp wrote: > >> >> Log: > >> >> Add linenumber and source filename to panic(9) output. > > This thread already represents a prime example of the worst of the > FreeBSD projects social dimension: The Gratuituos Bike Shed. > > On a generic kernel, this change adds 32088 non-executed bytes of > text-segment to i386/GENERIC. > > For reference this 0.5% of the kernel and 12% of the size of the > ACPI module. I'm not against this because of its size, I think it's the wrong way to go. > And yes, we can do much better, tracebacks would be a great start, > better panics also a great thing. We already have tracebacks if options DDB is enabled. (It probably should be for the GENERIC installed by sysinstall). > And no, this does not solve the mid-east crisis, but it is still > an improvement, even for me: If I save 1 minute because I do not > have to hunt for the panic in the first place, then that is one > minute more I can spend on the code. > > So if this makes your eyes water, I suggest you comment it out in > your local source tree and pop in on the next meeting in your > local user-group for some much needed perspective. The 10 seconds of grep time (guess I'm faster on this) is far outweighed by the one to INF email roundtrips necessary to get a user to enable options DDB, recompile, set up a serial console, etc. Most panics are page faults so you have to go to the traceback anyway as knowing the file/line of the page fault handler is not useful. I appreciate your desire to improve debugging and hope you'll be interested in tackling some of the outstanding issues (like the ones I listed). -Nate