From owner-cvs-all@FreeBSD.ORG Sun Oct 31 02:52:35 2010 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EE427106566B for ; Sun, 31 Oct 2010 02:52:35 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx23.fluidhosting.com [204.14.89.6]) by mx1.freebsd.org (Postfix) with ESMTP id 94A0D8FC0C for ; Sun, 31 Oct 2010 02:52:35 +0000 (UTC) Received: (qmail 22981 invoked by uid 399); 31 Oct 2010 02:52:33 -0000 Received: from localhost (HELO doug-optiplex.ka9q.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 31 Oct 2010 02:52:33 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4CCCD9EF.7010805@FreeBSD.org> Date: Sat, 30 Oct 2010 19:52:31 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.12) Gecko/20101028 Thunderbird/3.1.6 MIME-Version: 1.0 To: Johan van Selst References: <201010310036.o9V0aWIb042119@repoman.freebsd.org> In-Reply-To: <201010310036.o9V0aWIb042119@repoman.freebsd.org> X-Enigmail-Version: 1.1.2 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/squid31 Makefile distinfo ports/www/squid31/files squid.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2010 02:52:36 -0000 If -f ${squid_conf} is not optional (which from the script it would appear that it is not) then it should be in command_args, not _flags lest the user accidentally delete it. Of course you would then have to add $command_args to the various places in the script where _flags is currently present. Please pass this along to the maintainer, since you didn't include their e-mail address in the commit log ... Doug On 10/30/10 17:36, Johan van Selst wrote: > johans 2010-10-31 00:36:32 UTC > > FreeBSD ports repository > > Modified files: > www/squid31 Makefile distinfo > www/squid31/files squid.in > Log: > - Update squid to 3.1.9 > - Replace two dead mirrors > - Fix a bug in the squid rc script that caused the squid_conf > rc.conf option to be non-functional > > PR: ports/151760 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=151760 > Submitted by: Thomas-Martin Seck (maintainer) > > Revision Changes Path > 1.248 +3 -3 ports/www/squid31/Makefile > 1.190 +3 -3 ports/www/squid31/distinfo > 1.8 +2 -1 ports/www/squid31/files/squid.in > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/squid31/Makefile.diff?&r1=1.247&r2=1.248&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/squid31/distinfo.diff?&r1=1.189&r2=1.190&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/squid31/files/squid.in.diff?&r1=1.7&r2=1.8&f=h > -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/