From owner-svn-src-head@freebsd.org Wed May 22 21:52:54 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F3E8D15B89E1; Wed, 22 May 2019 21:52:53 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it1-f181.google.com (mail-it1-f181.google.com [209.85.166.181]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A26CE6CDEE; Wed, 22 May 2019 21:52:52 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it1-f181.google.com with SMTP id h20so6232687itk.4; Wed, 22 May 2019 14:52:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=jqA1L3zQXMVzh4JGM08R8YGQRXvBD+wJnU6/1d1ZL0c=; b=reuLKbSl7cwoNZ+tL3oYDuo6XtyFXsqkxB6sxM3zn6OU7ag8Mlb+Jwamx5hOsgNjQH aOrw4PIk+B6/X82bbuy59StTTVRsfnjGiqrm4H/2V06gmsEphZcnwMV9Abawm4wNl5g8 f92PgzXS8YNg0I+7nYPapM51VwoPCWpLyVkvLC9DpcJ0FelOInhWsSwUXFRgwyz9RjHD uLwD9FTnIwIxjniRogrFNDNhc6WCh5gtr4RnovWmT205wMoRuH9gQBT4+n0ZOXIP4s7l NAvZVtaQ5CKN0FcHzzAsxv4gYM2hQNT7cd08uo+M8eXwrzqycvB6Vv9GOg6ihUuL+tjW 4Ogw== X-Gm-Message-State: APjAAAUqyUpuu7OdfK6618OrYrmZP8cdm8Anfo7o9ZP1txDCFQHAT5kk LddCPFVDdxiA/fxaFdaULPZ05qki X-Google-Smtp-Source: APXvYqznPyGwei/e/yKvhNTTHTi/wb0WnOkMfeN0BmrJHEuuT2i92aVt9ltqUglNpmDFl2Hx+l0NwQ== X-Received: by 2002:a24:c241:: with SMTP id i62mr9964591itg.21.1558561971125; Wed, 22 May 2019 14:52:51 -0700 (PDT) Received: from mail-it1-f170.google.com (mail-it1-f170.google.com. [209.85.166.170]) by smtp.gmail.com with ESMTPSA id w139sm3926576ita.43.2019.05.22.14.52.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 May 2019 14:52:50 -0700 (PDT) Received: by mail-it1-f170.google.com with SMTP id m3so6265126itl.1; Wed, 22 May 2019 14:52:50 -0700 (PDT) X-Received: by 2002:a24:47cc:: with SMTP id t195mr10061944itb.117.1558561970599; Wed, 22 May 2019 14:52:50 -0700 (PDT) MIME-Version: 1.0 References: <201905160109.x4G19DhY080690@repo.freebsd.org> In-Reply-To: Reply-To: cem@freebsd.org From: Conrad Meyer Date: Wed, 22 May 2019 14:52:39 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r347638 - in head: . etc lib/libc/gen To: Brad Davis Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A26CE6CDEE X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of csecem@gmail.com designates 209.85.166.181 as permitted sender) smtp.mailfrom=csecem@gmail.com X-Spamd-Result: default: False [-5.78 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[cem@freebsd.org]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_ALL(0.00)[]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.98)[-0.985,0]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[181.166.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-2.79)[ip: (-8.15), ipnet: 209.85.128.0/17(-3.46), asn: 15169(-2.28), country: US(-0.06)]; RWL_MAILSPIKE_POSSIBLE(0.00)[181.166.85.209.rep.mailspike.net : 127.0.0.17] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 May 2019 21:52:54 -0000 Hi Brad, Ping. It's still broken. Can you revert this please? Thanks, Conrad On Thu, May 16, 2019 at 8:05 AM Conrad Meyer wrote: > > Hi Brad, > > Can you revert this? It seems to break every config-management tool > we have (mergemaster, etcupdate, beinstall ...). > > Additionally, I don't believe this move has been justified =E2=80=94 the = cons > seem to outweigh the pros, if there are any. I skimmed the > differential and it was not immediately obvious what the benefit was. > The commit message describes what was changed, but not *why* you > thought it was a good idea. > > Thanks, > Conrad > > On Wed, May 15, 2019 at 6:09 PM Brad Davis wrote: > > > > Author: brd > > Date: Thu May 16 01:09:13 2019 > > New Revision: 347638 > > URL: https://svnweb.freebsd.org/changeset/base/347638 > > > > Log: > > Move master.passwd and group to lib/libc/gen/ > > > > libc was picked as the destination location for these because of the = syscalls > > that use these files as the lowest level place they are referenced. > > > > Approved by: will (mentor), rgrimes, manu > > Differential Revision: https://reviews.freebsd.org/D16728 > > > > Added: > > head/lib/libc/gen/group > > - copied unchanged from r347637, head/etc/group > > head/lib/libc/gen/master.passwd > > - copied unchanged from r347637, head/etc/master.passwd > > Deleted: > > head/etc/group > > head/etc/master.passwd > > Modified: > > head/Makefile.inc1 > > head/etc/Makefile > > head/lib/libc/gen/Makefile.inc > > > > Modified: head/Makefile.inc1 > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/Makefile.inc1 Thu May 16 00:53:54 2019 (r347637) > > +++ head/Makefile.inc1 Thu May 16 01:09:13 2019 (r347638) > > @@ -871,8 +871,8 @@ DB_FROM_SRC=3D yes > > .endif > > > > .if defined(DB_FROM_SRC) > > -INSTALLFLAGS+=3D -N ${.CURDIR}/etc > > -MTREEFLAGS+=3D -N ${.CURDIR}/etc > > +INSTALLFLAGS+=3D -N ${.CURDIR}/lib/libc/gen > > +MTREEFLAGS+=3D -N ${.CURDIR}/lib/libc/gen > > .endif > > _INSTALL_DDIR=3D ${DESTDIR}/${DISTDIR} > > INSTALL_DDIR=3D ${_INSTALL_DDIR:S://:/:g:C:/$::} > > > > Modified: head/etc/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/etc/Makefile Thu May 16 00:53:54 2019 (r347637) > > +++ head/etc/Makefile Thu May 16 01:09:13 2019 (r347638) > > @@ -15,7 +15,6 @@ SUBDIR+=3Dsendmail > > .endif > > > > BIN1=3D \ > > - group \ > > login.access \ > > rc.bsdextended \ > > rc.firewall \ > > @@ -65,21 +64,7 @@ distribution: > > .endif > > cd ${.CURDIR}; \ > > ${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 644 \ > > - ${BIN1} ${DESTDIR}/etc; \ > > - ${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 600 \ > > - master.passwd ${DESTDIR}/etc; > > - > > -.if ${MK_TCSH} =3D=3D "no" > > - sed -i "" -e 's;/bin/csh;/bin/sh;' ${DESTDIR}/etc/master.passwd > > -.endif > > - pwd_mkdb -i -p -d ${DESTDIR}/etc ${DESTDIR}/etc/master.passwd > > -.if defined(NO_ROOT) > > - ( \ > > - echo "./etc/passwd type=3Dfile mode=3D0644 uname=3Droot= gname=3Dwheel"; \ > > - echo "./etc/pwd.db type=3Dfile mode=3D0644 uname=3Droot= gname=3Dwheel"; \ > > - echo "./etc/spwd.db type=3Dfile mode=3D0600 uname=3Droo= t gname=3Dwheel"; \ > > - ) | ${METALOG.add} > > -.endif > > + ${BIN1} ${DESTDIR}/etc > > ${_+_}cd ${.CURDIR}/gss; ${MAKE} install > > ${_+_}cd ${.CURDIR}/mtree; ${MAKE} install > > ${_+_}cd ${SRCTOP}/share/termcap; ${MAKE} etc-termcap > > > > Modified: head/lib/libc/gen/Makefile.inc > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/lib/libc/gen/Makefile.inc Thu May 16 00:53:54 2019 = (r347637) > > +++ head/lib/libc/gen/Makefile.inc Thu May 16 01:09:13 2019 = (r347638) > > @@ -4,7 +4,8 @@ > > # machine-independent gen sources > > .PATH: ${LIBC_SRCTOP}/${LIBC_ARCH}/gen ${LIBC_SRCTOP}/gen > > > > -CONFS=3D shells > > +CONFS+=3D group master.passwd shells > > +CONFSMODE_master.passwd=3D 600 > > > > SRCS+=3D __getosreldate.c \ > > __pthread_mutex_init_calloc_cb_stub.c \ > > @@ -543,3 +544,16 @@ MLINKS+=3Dvis.3 nvis.3 \ > > vis.3 svis.3 > > > > MLINKS+=3Dwordexp.3 wordfree.3 > > + > > +afterinstallconfig: > > +.if ${MK_TCSH} =3D=3D "no" > > + sed -i "" -e 's;/bin/csh;/bin/sh;' ${DESTDIR}/etc/master.passwd > > +.endif > > + pwd_mkdb -i -p -d ${DESTDIR}/etc ${DESTDIR}/etc/master.passwd > > +.if defined(NO_ROOT) && defined(METALOG) > > + ( \ > > + echo "./etc/pwd.db type=3Dfile mode=3D0644 uname=3Droot= gname=3Dwheel"; \ > > + echo "./etc/spwd.db type=3Dfile mode=3D0600 uname=3Droo= t gname=3Dwheel"; \ > > + echo "./etc/passwd type=3Dfile mode=3D0644 uname=3Droot= gname=3Dwheel"; \ > > + ) | cat -l >> ${METALOG} > > +.endif > > > > Copied: head/lib/libc/gen/group (from r347637, head/etc/group) > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/lib/libc/gen/group Thu May 16 01:09:13 2019 (r34763= 8, copy of r347637, head/etc/group) > > @@ -0,0 +1,36 @@ > > +# $FreeBSD$ > > +# > > +wheel:*:0:root > > +daemon:*:1: > > +kmem:*:2: > > +sys:*:3: > > +tty:*:4: > > +operator:*:5:root > > +mail:*:6: > > +bin:*:7: > > +news:*:8: > > +man:*:9: > > +games:*:13: > > +ftp:*:14: > > +staff:*:20: > > +sshd:*:22: > > +smmsp:*:25: > > +mailnull:*:26: > > +guest:*:31: > > +video:*:44: > > +bind:*:53: > > +unbound:*:59: > > +proxy:*:62: > > +authpf:*:63: > > +_pflogd:*:64: > > +_dhcp:*:65: > > +uucp:*:66: > > +dialer:*:68: > > +network:*:69: > > +audit:*:77: > > +www:*:80: > > +ntpd:*:123: > > +_ypldap:*:160: > > +hast:*:845: > > +nogroup:*:65533: > > +nobody:*:65534: > > > > Copied: head/lib/libc/gen/master.passwd (from r347637, head/etc/master.= passwd) > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/lib/libc/gen/master.passwd Thu May 16 01:09:13 2019 = (r347638, copy of r347637, head/etc/master.passwd) > > @@ -0,0 +1,28 @@ > > +# $FreeBSD$ > > +# > > +root::0:0::0:0:Charlie &:/root:/bin/csh > > +toor:*:0:0::0:0:Bourne-again Superuser:/root: > > +daemon:*:1:1::0:0:Owner of many system processes:/root:/usr/sbin/nolog= in > > +operator:*:2:5::0:0:System &:/:/usr/sbin/nologin > > +bin:*:3:7::0:0:Binaries Commands and Source:/:/usr/sbin/nologin > > +tty:*:4:65533::0:0:Tty Sandbox:/:/usr/sbin/nologin > > +kmem:*:5:65533::0:0:KMem Sandbox:/:/usr/sbin/nologin > > +games:*:7:13::0:0:Games pseudo-user:/:/usr/sbin/nologin > > +news:*:8:8::0:0:News Subsystem:/:/usr/sbin/nologin > > +man:*:9:9::0:0:Mister Man Pages:/usr/share/man:/usr/sbin/nologin > > +sshd:*:22:22::0:0:Secure Shell Daemon:/var/empty:/usr/sbin/nologin > > +smmsp:*:25:25::0:0:Sendmail Submission User:/var/spool/clientmqueue:/u= sr/sbin/nologin > > +mailnull:*:26:26::0:0:Sendmail Default User:/var/spool/mqueue:/usr/sbi= n/nologin > > +bind:*:53:53::0:0:Bind Sandbox:/:/usr/sbin/nologin > > +unbound:*:59:59::0:0:Unbound DNS Resolver:/var/unbound:/usr/sbin/nolog= in > > +proxy:*:62:62::0:0:Packet Filter pseudo-user:/nonexistent:/usr/sbin/no= login > > +_pflogd:*:64:64::0:0:pflogd privsep user:/var/empty:/usr/sbin/nologin > > +_dhcp:*:65:65::0:0:dhcp programs:/var/empty:/usr/sbin/nologin > > +uucp:*:66:66::0:0:UUCP pseudo-user:/var/spool/uucppublic:/usr/local/li= bexec/uucp/uucico > > +pop:*:68:6::0:0:Post Office Owner:/nonexistent:/usr/sbin/nologin > > +auditdistd:*:78:77::0:0:Auditdistd unprivileged user:/var/empty:/usr/s= bin/nologin > > +www:*:80:80::0:0:World Wide Web Owner:/nonexistent:/usr/sbin/nologin > > +ntpd:*:123:123::0:0:NTP Daemon:/var/db/ntp:/usr/sbin/nologin > > +_ypldap:*:160:160::0:0:YP LDAP unprivileged user:/var/empty:/usr/sbin/= nologin > > +hast:*:845:845::0:0:HAST unprivileged user:/var/empty:/usr/sbin/nologi= n > > +nobody:*:65534:65534::0:0:Unprivileged user:/nonexistent:/usr/sbin/nol= ogin > >