From nobody Thu Jul 17 15:59:07 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bjczv6YLcz61wSW; Thu, 17 Jul 2025 15:59:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bjczv5pSbz3bgj; Thu, 17 Jul 2025 15:59:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752767947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iwvTClAg4DoxaC3IrXjtjN7k9pLdAcW2gfOHaKn9v48=; b=HKnQSDijXBMWyRVDuX/Nw4qfybxuUFIuHKhAS8ckM0F+eKyVF42rYLogR4IgRFHmfaSmO3 ykdiBIehh5ylGSZLLNQ55rOYG7tkn4hMh75aygkaAZV+0b7miE3QScNqDm+dONvvdg1g1Q fSiqmBBfVolH2YCeDXmGDyRB+GXEpP4N9WTFuRqY//6dTHCFHrdxXPorkvNrloQMYC2W1S hfOWL0CVc6iWed11XH3/OzsQ/Ag11AeF24qvlsgXiVbosITD2evg4sKsZGSxlZn3IpcqIY RV1RTUJ28aww2esU7ADZgAdPShB8nwsYG6Rp0u5CXzUnmiWqxOG9BBLQwInVMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752767947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iwvTClAg4DoxaC3IrXjtjN7k9pLdAcW2gfOHaKn9v48=; b=w3BcLu0bWgGg2NMnurWt4s4o5uPhlK4deklP2eItBiJ7HNnwKNoCgdNRTJ+gLJmrD3Kn2X JyVNYj0id2MhHVgOkQLrDVokm6zL+PkOd4o0+46FzlEPLUaQOxncgKKa5GtbSykBvZOex0 lOJnXePDKUyHE9LTJ7UFTIoYyMd3OBprHk36ilTa+66QMC92jcLgRh/LJ3Ikpic6W+henZ o+mmpF1bI1tU5W4St03cwaOfUseePXOVBmZ9iLUNShOlO+bmY8th5ENlf37052wiTQMbzC fY9AskbwAzOU69qYY1Mol01PsKe3spo/VUNEonYuYwZHlMBUkxYoT4/X01SiBg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1752767947; a=rsa-sha256; cv=none; b=xNbltsnUR34bHayCVTA7BnT7mT8rorEdwpv6taQqJ4Nj9oRhBhTpKbA5vGKERu3HIBxNze 7XH/iy5r6Gt937p9FLEK/KPNHTkK+7imBzJ0wP2kx82aMtDCAtTxmlit7LZMgtTjOW5oz5 MBTEcVKFrxYHEd6bPVrRur3bZgzrOEY/49zT4wd8ZYZ2C0ayLdWSDeC3izlSoVLxVSLry5 8DSIrcwjHtt61k2hEiercqH1vvPExqtBUBcW1LEpV4sjJEconfwichlI3iJIYqBLOgHRni hf+qwIJTgMXq2yWofgqgsJ4Yhfw/51vg1AOoZ57xvtNqn9GA9zrhYU6ujG/yyg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bjczv5BmQz12FX; Thu, 17 Jul 2025 15:59:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56HFx70X018584; Thu, 17 Jul 2025 15:59:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56HFx79S018581; Thu, 17 Jul 2025 15:59:07 GMT (envelope-from git) Date: Thu, 17 Jul 2025 15:59:07 GMT Message-Id: <202507171559.56HFx79S018581@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: d4f042f094ec - main - libbsnmp: fix local client socket creation List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d4f042f094ec31447f127d6c4e15a8366dd32725 Auto-Submitted: auto-generated The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=d4f042f094ec31447f127d6c4e15a8366dd32725 commit d4f042f094ec31447f127d6c4e15a8366dd32725 Author: Gleb Smirnoff AuthorDate: 2025-07-17 15:57:56 +0000 Commit: Gleb Smirnoff CommitDate: 2025-07-17 15:57:56 +0000 libbsnmp: fix local client socket creation Revert "bsnmp: Use mkstemp when creating clients local socket" The use of mktemp() was intentional here. We don't want a regular file to be created. If created, it guarantees that following bind(2) would always fail with EADDRINUSE and thus open_client_local() always fails. This reverts commit 81e0e7b9e36d6a25b3af6482811318e085537d2f. Reviewed by: rew, harti Differential Revision: https://reviews.freebsd.org/D51031 --- contrib/bsnmp/lib/snmpclient.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/bsnmp/lib/snmpclient.c b/contrib/bsnmp/lib/snmpclient.c index b312a37ed3ed..a7556527ad51 100644 --- a/contrib/bsnmp/lib/snmpclient.c +++ b/contrib/bsnmp/lib/snmpclient.c @@ -1012,7 +1012,7 @@ open_client_local(const char *path) snprintf(snmp_client.local_path, sizeof(snmp_client.local_path), "%s", SNMP_LOCAL_PATH); - if (mkstemp(snmp_client.local_path) == -1) { + if (mktemp(snmp_client.local_path) == NULL) { seterr(&snmp_client, "%s", strerror(errno)); (void)close(snmp_client.fd); snmp_client.fd = -1;