From nobody Wed Jul 8 12:28:20 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gwHSP1234z6lGbD for ; Wed, 08 Jul 2026 12:28:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gwHSP0Gbhz3ZKj for ; Wed, 08 Jul 2026 12:28:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783513701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eL7YK/RmG70GUpPru4A/IRhBDmWfVWzVB9sQ+CWYhes=; b=C8vXWjqQx0/ftDRxOz897bDooUAOFl3vM6/pwf+GYddvIpXP6owPKArTLTB8oPB1oZvP14 v+7Oopr6yutjWuGeZ1BC1Ta1t33P1qXzpfT/JSaJA5DAfh2vH6EIw1TxG6OVg+L3Bkjuw6 H74f/mKkxB/frxu00wiBOsDV8FRcLKVAndoBWbHXYWa7Qct+i79dX2DtHBOM4zKBbg12Zo fUUrZjCPguOC68jIgrK0LHUTYIGxyFXKY5yfykGAyZIR17YqNSoPJ51p2BTdknxClbDKQk veNU/1OwVtBV5i6ZNy0Web1nOo/fuzusiib5qZ1cuG63VlEmnrlFNptwJ7z9Ng== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783513701; a=rsa-sha256; cv=none; b=ksACuKfwLRs7qNsyjkMEM35rMcZSLSijTHhJIeEs8T4NVBml+vEYFKDbGRlaszJV2yoOsV HTnWd+rhsKNIQrs0YxA6V0BlR4PBjjgpI4njhaoO0kaJGy4dFbvqiXWSe/E4rUiMfzt8HK iTKP5DSRrKEddo6VawTIEhIUAv2slC/LyvexwvKXhr8lAMIpeoUHQfylPJNLtkKZ8MrX0V pMlQav+hfrVu9/ACurvuPy6pN5DJpYWBE27FotsQ3gqafH0ZgHMUSTTT9057Fds4b90Hwe mRRvwfJkhZp23q3h9oD0asatD9YFCypO7TorUgc75OPnrz+noNXUL2roxJz0Ew== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783513701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eL7YK/RmG70GUpPru4A/IRhBDmWfVWzVB9sQ+CWYhes=; b=FGNZnAdJo3MsjYcaM65isWgtPuID1+T1RbmZm4XK9rYdbLhB1VCBLdbRi0jjgsxdWL47RR /PQFTGwV8PuULXqVPNbleVVUtCHXLSnJHsNRdNKePvpGdNA8pzqK07h2MhhA2J718N8FSN P2XJ0MONZta60ivNydaRfL2Yx8qtYkRT4qzZxl47/q5rH44x78g88OJ9aB/v6xuhgy1wlf 6zSLxJ5vJQSJFJHRKYQOFXrMSb1r7bmxhA3m7PvRpSKDvWcb1J/M5Jy3HnEMq63RbzEbC7 QqNtn8hPaE92Cw4uIOxB1vNDeqqom8ONfn2nV9E5InkJ1Pj2tnLtQ9kIqsuVIg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gwHSN62sDz5W6 for ; Wed, 08 Jul 2026 12:28:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3c2ad by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 08 Jul 2026 12:28:20 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Gallatin Subject: git: 1cce5ef05d7b - main - lagg: re-check port caps after bringing up a port List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gallatin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1cce5ef05d7ba077b0cb29d30b59f3a862e7e5ae Auto-Submitted: auto-generated Date: Wed, 08 Jul 2026 12:28:20 +0000 Message-Id: <6a4e4264.3c2ad.53e50a88@gitrepo.freebsd.org> The branch main has been updated by gallatin: URL: https://cgit.FreeBSD.org/src/commit/?id=1cce5ef05d7ba077b0cb29d30b59f3a862e7e5ae commit 1cce5ef05d7ba077b0cb29d30b59f3a862e7e5ae Author: Andrew Gallatin AuthorDate: 2026-07-08 12:24:35 +0000 Commit: Andrew Gallatin CommitDate: 2026-07-08 12:27:58 +0000 lagg: re-check port caps after bringing up a port Some nic drivers (including iflib) do not initialize if_hwassist until after the interface is brought up. If a lagg member is included in a lagg when its not yet been brought up, that will cause lagg to see if_hwassist=0 and will disable all checksum offload, etc, on the interface. This is almost impossible to debug without kgdb or dtrace, as ifconfig does not surface if_hwassist. Fix this by re-calculating lagg caps (including if_hwassist) after adding a port. I encountered this problem when I had a commented-out if_foo1=up entry in my rc.conf that i neglected to uncomment when I was re-configuring a lagg. Sponsored by: Netflix Reviewed by: markj, zlei Differential Revision: https://reviews.freebsd.org/D58062 --- sys/net/if_lagg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/net/if_lagg.c b/sys/net/if_lagg.c index da08e02d50be..e8e0306b0d1f 100644 --- a/sys/net/if_lagg.c +++ b/sys/net/if_lagg.c @@ -1309,6 +1309,8 @@ lagg_init_locked(struct lagg_softc *sc) lagg_if_updown(sc, true); + /* Recheck port caps; bringing them up may have changed if_hwassist. */ + lagg_capabilities(sc); lagg_proto_init(sc); if (ifp->if_type == IFT_INFINIBAND) {