From owner-svn-src-all@freebsd.org Tue May 7 18:22:54 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 01FD4158FEB4; Tue, 7 May 2019 18:22:54 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-it1-f172.google.com (mail-it1-f172.google.com [209.85.166.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 93EC46EE61; Tue, 7 May 2019 18:22:53 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-it1-f172.google.com with SMTP id l10so28092129iti.3; Tue, 07 May 2019 11:22:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wCmkblR0lpTgD8vPo/Hj2Mvztly4B51ZVHHZQ1MOAf4=; b=UOB9PUAlLECqMQRlZvpcG6D31zW+2wtXOZP3pT+1Cvxl6yK4X7sJMLUHDwIGg3u3Te Xda4sgCZe6mor7LRzfchpb1Fm9zmaEMvDZpfm9X3oMQiHcS9k4jHO761v+FrgqWYaXgX GZczucmKJp6vIJmIArCpX4eH29npujAUDbE4BAntEv8IjetJixZrLseumHOCbSXtaIZ+ xRmHragDV/qcvISl5zNbXKmv7S+EemeisFYtO3gFYn7PUz/Oo8SEnjKin+Dad+vIvcog RNmw6Q8cTrAVfX50vP89lYS+Uap339Im0KmHcmtmtXw4NaAz26y6Y4C09Q82yC2t0WH1 CT+w== X-Gm-Message-State: APjAAAWNFo2FBxAG9NQ0nJrgFVaaJItjKB7whjqzLL8uvLM/Kyqs/oXS 6FAQy79DBzhs8luVA3YJ8RWje1sk+Vz9wbz/tI1c+5Bk X-Google-Smtp-Source: APXvYqzilqcHE+pUl9qGDHkdChlkZ2YLXvsgK5tko1i0v3GMKCUQZfHrJ0j6EYjQReVM0MWcU4Izqtsp6/gPXIPW8SM= X-Received: by 2002:a05:6638:606:: with SMTP id g6mr24433384jar.129.1557252903517; Tue, 07 May 2019 11:15:03 -0700 (PDT) MIME-Version: 1.0 References: <201905071617.x47GHXB0065438@repo.freebsd.org> In-Reply-To: From: Ed Maste Date: Tue, 7 May 2019 02:03:50 -0400 Message-ID: Subject: Re: svn commit: r347228 - head/sys/kern To: Ravi Pokala Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 93EC46EE61 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.91 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.91)[-0.907,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 May 2019 18:22:54 -0000 On Tue, 7 May 2019 at 13:00, Ravi Pokala wrote: > > > + # Avoid a literal generated file tag here. > > + generated = "@" "generated"; > > + > > Why is that needed here, but not in r347224? It is, see https://reviews.freebsd.org/D20182