From owner-freebsd-current@FreeBSD.ORG Sat Sep 12 19:12:08 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F083D10656A5; Sat, 12 Sep 2009 19:12:08 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello087206049004.chello.pl [87.206.49.4]) by mx1.freebsd.org (Postfix) with ESMTP id 3E31D8FC15; Sat, 12 Sep 2009 19:12:07 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 83F8E45C98; Sat, 12 Sep 2009 21:12:06 +0200 (CEST) Received: from localhost (chello087206049004.chello.pl [87.206.49.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 4A1504569A; Sat, 12 Sep 2009 21:12:01 +0200 (CEST) Date: Sat, 12 Sep 2009 21:11:58 +0200 From: Pawel Jakub Dawidek To: Kris Kennaway Message-ID: <20090912191158.GA2091@garage.freebsd.pl> References: <4AA40E30.50109@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VbJkn9YxBvnuCH5J" Content-Disposition: inline In-Reply-To: <4AA40E30.50109@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: Jaakko Heinonen , Kip Macy , FreeBSD Current Subject: Re: panic: sx_xlock() of destroyed sx @ /zoo/kris/src8/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_rlock.c:535 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Sep 2009 19:12:09 -0000 --VbJkn9YxBvnuCH5J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 06, 2009 at 08:32:00PM +0100, Kris Kennaway wrote: > 9.0 doing I/O to a zfs: >=20 > panic: sx_xlock() of destroyed sx @=20 > /zoo/kris/src8/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/= fs/zfs/zfs_rlock.c:535 > db> wh > Tracing pid 14 tid 100047 td 0xffffff000357c720 > kdb_enter() at kdb_enter+0x3d > panic() at panic+0x17b > _sx_xlock() at _sx_xlock+0xe9 > zfs_range_unlock() at zfs_range_unlock+0x38 > zfs_get_data() at zfs_get_data+0xd7 > zil_commit() at zil_commit+0x532 > zfs_sync() at zfs_sync+0xa6 > sync_fsync() at sync_fsync+0x13a > VOP_FSYNC_APV() at VOP_FSYNC_APV+0xb7 > sync_vnode() at sync_vnode+0x157 > sched_sync() at sched_sync+0x1d1 > fork_exit() at fork_exit+0x12a > fork_trampoline() at fork_trampoline+0xe > --- trap 0, rip =3D 0, rsp =3D 0xffffff8125da0d30, rbp =3D 0 --- >=20 > This was essentially just doing make world + cvs update + tar creation=20 > in a loop and failed after about a week. Ok, here is a patch to try: http://people.freebsd.org/~pjd/patches/zfs_races.patch Actually I think I'll just commit it as I was able to reproduce and understand your problem. The patch fixes three races: - The check to see that we lost race in zfs_zget() wasn't tight enough. This was found by Jaakko Heinonen and part of the patch is based on his work. - There was a race where rollback could be called between zfs_freebsd_reclaim() and zfs_reclaim_complete(). - There was a race where forced unmount could be called between zfs_freebsd_reclaim() and zfs_reclaim_complete(). --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --VbJkn9YxBvnuCH5J Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFKq/J+ForvXbEpPzQRAvq1AKCQv76of165XEVM1UogksBvYJjMoACg5DQF odE/ziQRpYGrHvWi0HMzKY4= =85gN -----END PGP SIGNATURE----- --VbJkn9YxBvnuCH5J--