Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 01 May 2006 19:08:58 -0700
From:      Maxim Sobolev <sobomax@FreeBSD.org>
To:        Scott Long <scottl@samsco.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Scott Long <scottl@FreeBSD.org>, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/share/man/man4 Makefile rr232x.4 src/sys/dev/rr232x LICENSE README amd64-elf.rr232x_lib.o.uu         array.h him.h himfuncs.h hptintf.h i386-elf.rr232x_lib.o.uu ldm.h         list.h os_bsd.c os_bsd.h osm.h osm_bsd.c rr232x_config.c ...
Message-ID:  <4456BF3A.7090801@FreeBSD.org>
In-Reply-To: <4456BC5A.2090308@samsco.org>
References:  <200605010015.k410FDef095624@repoman.freebsd.org> <4456B86D.2080207@FreeBSD.org> <4456BC5A.2090308@samsco.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Scott Long wrote:
> The architecture of the driver makes this a request hard to do.  I don't 
> like it, but there is precedence already with the ath driver.

Hmm, can't you just move respective printf from the hpt_init to htp_probe?

-Maxim

> 
> Scott
> 
> 
> Maxim Sobolev wrote:
>> Can you please change it so that the driver doesn't announce itself 
>> into dmesg unless the probe has been successful? This is I believe 
>> BSD-way to do things and what the rest of non-isa drivers out there do.
>>
>> Thanks!
>>
>> Regards,
>>
>> Maxim
>>
>> Scott Long wrote:
>>
>>> scottl      2006-05-01 00:15:13 UTC
>>>
>>>   FreeBSD src repository
>>>
>>>   Modified files:        (Branch: RELENG_6_1)
>>>     share/man/man4       Makefile     sys/conf             
>>> files.amd64 files.i386     sys/i386/conf        GENERIC NOTES     
>>> sys/amd64/conf       GENERIC NOTES   Added files:           (Branch: 
>>> RELENG_6_1)
>>>     share/man/man4       rr232x.4     sys/dev/rr232x       LICENSE 
>>> README amd64-elf.rr232x_lib.o.uu                          array.h 
>>> him.h himfuncs.h hptintf.h                          
>>> i386-elf.rr232x_lib.o.uu ldm.h list.h                          
>>> os_bsd.c os_bsd.h osm.h osm_bsd.c                          
>>> rr232x_config.c rr232x_config.h     sys/modules/rr232x   Makefile   Log:
>>>   MFC The rr232x driver.
>>>     Approved by: re.
>>>     Revision        Changes    Path
>>>   1.320.2.10.2.2  +2 -0      src/share/man/man4/Makefile
>>>   1.2.4.1         +99 -0     src/share/man/man4/rr232x.4 (new)
>>>   1.439.2.9.2.2   +1 -0      src/sys/amd64/conf/GENERIC
>>>   1.36.2.9.2.1    +5 -0      src/sys/amd64/conf/NOTES
>>>   1.71.2.6.2.1    +7 -0      src/sys/conf/files.amd64
>>>   1.538.2.5.2.1   +8 -0      src/sys/conf/files.i386
>>>   1.1.4.1         +30 -0     src/sys/dev/rr232x/LICENSE (new)
>>>   1.1.4.1         +202 -0    src/sys/dev/rr232x/README (new)
>>>   1.1.4.1         +4567 -0   
>>> src/sys/dev/rr232x/amd64-elf.rr232x_lib.o.uu (new)
>>>   1.1.4.1         +179 -0    src/sys/dev/rr232x/array.h (new)
>>>   1.1.4.1         +440 -0    src/sys/dev/rr232x/him.h (new)
>>>   1.1.4.1         +100 -0    src/sys/dev/rr232x/himfuncs.h (new)
>>>   1.1.4.1         +1647 -0   src/sys/dev/rr232x/hptintf.h (new)
>>>   1.1.4.1         +3068 -0   
>>> src/sys/dev/rr232x/i386-elf.rr232x_lib.o.uu (new)
>>>   1.1.4.1         +484 -0    src/sys/dev/rr232x/ldm.h (new)
>>>   1.1.4.1         +121 -0    src/sys/dev/rr232x/list.h (new)
>>>   1.1.4.1         +297 -0    src/sys/dev/rr232x/os_bsd.c (new)
>>>   1.2.4.1         +255 -0    src/sys/dev/rr232x/os_bsd.h (new)
>>>   1.1.4.1         +199 -0    src/sys/dev/rr232x/osm.h (new)
>>>   1.1.4.1         +1351 -0   src/sys/dev/rr232x/osm_bsd.c (new)
>>>   1.1.4.1         +31 -0     src/sys/dev/rr232x/rr232x_config.c (new)
>>>   1.1.4.1         +107 -0    src/sys/dev/rr232x/rr232x_config.h (new)
>>>   1.429.2.7.2.2   +1 -0      src/sys/i386/conf/GENERIC
>>>   1.1202.2.6.2.1  +5 -0      src/sys/i386/conf/NOTES
>>>   1.2.4.1         +22 -0     src/sys/modules/rr232x/Makefile (new)
>>>
>>>
>>
> 
> 




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4456BF3A.7090801>