From owner-freebsd-bugs  Tue May 23 18:50:02 1995
Return-Path: bugs-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id SAA24576
          for bugs-outgoing; Tue, 23 May 1995 18:50:02 -0700
Received: (from gnats@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id SAA24569
          ; Tue, 23 May 1995 18:50:01 -0700
Date: Tue, 23 May 1995 18:50:01 -0700
Message-Id: <199505240150.SAA24569@freefall.cdrom.com>
From: Mike Grupenhoff <kashmir@umiacs.UMD.EDU>
Reply-To: Mike Grupenhoff <kashmir@umiacs.UMD.EDU>
To: freebsd-bugs
Subject: bin/439: pppd: fprintf had too few arguments (with fix)
In-Reply-To: Your message of Tue, 23 May 1995 21:46:36 -0400
	<199505240146.VAA01692@snarf.umiacs.umd.edu>
Sender: bugs-owner@FreeBSD.org
Precedence: bulk


>Number:         439
>Category:       bin
>Synopsis:       pppd: fprintf had too few arguments (with fix)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs (FreeBSD bugs mailing list)
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 23 18:50:01 1995
>Originator:     Mike Grupenhoff
>Organization:
>Release:        FreeBSD 2.0.0-SNAP950322 i386
>Environment:

FreeBSD 2.0.0-SNAP950322 (also in current)

>Description:

An error message in pppd calls fprintf with too few arguments, usually causing
a seg fault.

>How-To-Repeat:

pppd [...] escape 0x2b [...]

>Fix:

/usr/src/usr.sbin/pppd/options.c

--- options.c.orig      Tue May 23 21:40:54 1995
+++ options.c   Tue May 23 21:41:21 1995
@@ -1009,7 +1009,7 @@
        }
        p = endp;
        if (n < 0 || 0x20 <= n && n <= 0x3F || n == 0x5E || n > 0xFF) {
-           fprintf(stderr, "%s: can't escape character 0x%x\n", n);
+           fprintf(stderr, "%s: can't escape character 0x%x\n", progname, n);
            ret = 0;
        } else
            xmit_accm[0][n >> 5] |= 1 << (n & 0x1F);

>Audit-Trail:
>Unformatted: