From owner-svn-src-head@freebsd.org  Fri Feb 22 15:09:12 2019
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 80AB614EF088;
 Fri, 22 Feb 2019 15:09:12 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au
 [211.29.132.246])
 by mx1.freebsd.org (Postfix) with ESMTP id E44B2707D3;
 Fri, 22 Feb 2019 15:09:11 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from [192.168.0.102] (c110-21-101-228.carlnfd1.nsw.optusnet.com.au
 [110.21.101.228])
 by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 7A752436F52;
 Sat, 23 Feb 2019 02:09:08 +1100 (AEDT)
Date: Sat, 23 Feb 2019 02:09:07 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: David Bright <dab@freebsd.org>
cc: src-committers@freebsd.org, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Subject: Re: svn commit: r344468 - head/usr.sbin/newsyslog
In-Reply-To: <201902221459.x1MExegD026299@repo.freebsd.org>
Message-ID: <20190223020739.H33323@besplex.bde.org>
References: <201902221459.x1MExegD026299@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.2 cv=FNpr/6gs c=1 sm=1 tr=0
 a=PalzARQSbocsUSjMRkwAPg==:117 a=PalzARQSbocsUSjMRkwAPg==:17
 a=kj9zAlcOel0A:10 a=Mu5RLQuuxLdgbZ8lhckA:9 a=CjuIK1q_8ugA:10
X-Rspamd-Queue-Id: E44B2707D3
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.94 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-1.000,0];
 NEURAL_HAM_SHORT(-0.94)[-0.937,0];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Feb 2019 15:09:12 -0000

On Fri, 22 Feb 2019, David Bright wrote:

> Log:
>  Revert r344389 & r343906 - Fix Coverity errors in newsyslog
>
>  It was pointed out that a couple of the "memory leak" CIDs that I
>  fixed were arguably Coverity errors rather than errors in the
>  newsyslog code and the cure was worse than the disease. Revert both
>  changes. The first change, which included fixes for other Coverity
>  errors, will be re-worked to omit the troublesome changes and then
>  re-committed with the remaining fixes.
>
>  Reported by:	bde
>  Sponsored by:	Dell EMC Isilon

Thanks.  The other changes look OK.

Bruce